Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Write unbiased states only for smoothed in RootTrackStatesWriter #3561

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Aug 27, 2024

Deduplicating the unbiased states in RootTrackStatesWriter by only deriving them from the smoothed states. I believe for other states than smoothed this formalism does not make sense.

blocked by

@andiwand andiwand added this to the next milestone Aug 27, 2024
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Aug 27, 2024
Copy link

github-actions bot commented Aug 27, 2024

📊: Physics performance monitoring for 8784ff1

Full contents

physmon summary

@andiwand andiwand added the 🛑 blocked This item is blocked by another item label Sep 2, 2024
@andiwand andiwand removed the 🛑 blocked This item is blocked by another item label Sep 3, 2024
@andiwand andiwand marked this pull request as ready for review September 3, 2024 13:31
AJPfleger
AJPfleger previously approved these changes Sep 3, 2024
Copy link

sonarcloud bot commented Sep 5, 2024

@kodiakhq kodiakhq bot merged commit f3a5477 into acts-project:main Sep 5, 2024
42 checks passed
@github-actions github-actions bot removed the automerge label Sep 5, 2024
@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Sep 5, 2024
@andiwand andiwand deleted the refactor-roottrackstateswriter-unbiased-only-for-smoothed branch September 5, 2024 18:52
@paulgessinger paulgessinger modified the milestones: next, v37.0.0 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Changes Performance Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants