-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add pre-commit hooks for most of our linting #3560
Merged
kodiakhq
merged 5 commits into
acts-project:main
from
paulgessinger:chore/pre-commit-all-the-things
Aug 27, 2024
Merged
ci: Add pre-commit hooks for most of our linting #3560
kodiakhq
merged 5 commits into
acts-project:main
from
paulgessinger:chore/pre-commit-all-the-things
Aug 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulgessinger
changed the title
fix spelling
ci: Add pre-commit hooks for most of our linting
Aug 27, 2024
paulgessinger
requested review from
AJPfleger,
andiwand and
benjaminhuth
and removed request for
AJPfleger and
andiwand
August 27, 2024 08:30
github-actions
bot
added
Infrastructure
Changes to build tools, continous integration, ...
Component - Fatras
Affects the Fatras module
Component - Documentation
Affects the documentation
labels
Aug 27, 2024
paulgessinger
force-pushed
the
chore/pre-commit-all-the-things
branch
from
August 27, 2024 08:34
51dbaad
to
53a43b1
Compare
benjaminhuth
previously approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
paulgessinger
force-pushed
the
chore/pre-commit-all-the-things
branch
from
August 27, 2024 08:44
53a43b1
to
1b4bc09
Compare
@benjaminhuth I messed up the |
benjaminhuth
previously approved these changes
Aug 27, 2024
benjaminhuth
approved these changes
Aug 27, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Documentation
Affects the documentation
Component - Fatras
Affects the Fatras module
Infrastructure
Changes to build tools, continous integration, ...
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use pre-commit for more of our linting. I'm adding local-only hooks for most of the check scripts we run in the CI, and I'm adding a codespell hook.
The pre-commit CI job will now implicitly also run these checks, but I suggest we keep the dedicated jobs for now and remove them at a later time if we want.