Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add pre-commit hooks for most of our linting #3560

Merged

Conversation

paulgessinger
Copy link
Member

Use pre-commit for more of our linting. I'm adding local-only hooks for most of the check scripts we run in the CI, and I'm adding a codespell hook.

The pre-commit CI job will now implicitly also run these checks, but I suggest we keep the dedicated jobs for now and remove them at a later time if we want.

@paulgessinger paulgessinger added this to the next milestone Aug 27, 2024
@paulgessinger paulgessinger changed the title fix spelling ci: Add pre-commit hooks for most of our linting Aug 27, 2024
@paulgessinger paulgessinger requested review from AJPfleger, andiwand and benjaminhuth and removed request for AJPfleger and andiwand August 27, 2024 08:30
@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Component - Fatras Affects the Fatras module Component - Documentation Affects the documentation labels Aug 27, 2024
@paulgessinger paulgessinger force-pushed the chore/pre-commit-all-the-things branch from 51dbaad to 53a43b1 Compare August 27, 2024 08:34
benjaminhuth
benjaminhuth previously approved these changes Aug 27, 2024
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@paulgessinger
Copy link
Member Author

@benjaminhuth I messed up the CMakeLists.txt format, can you click again?

benjaminhuth
benjaminhuth previously approved these changes Aug 27, 2024
Copy link

github-actions bot commented Aug 27, 2024

📊: Physics performance monitoring for f91f0e3

Full contents

physmon summary

Copy link

sonarcloud bot commented Aug 27, 2024

@kodiakhq kodiakhq bot merged commit b7f0222 into acts-project:main Aug 27, 2024
42 checks passed
@andiwand andiwand modified the milestones: next, v36.3.0 Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Documentation Affects the documentation Component - Fatras Affects the Fatras module Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants