Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add B-field accessors to Python bindings #3554

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

stephenswat
Copy link
Member

As #3479 reveals, we don't currently have any clean, cache-aware ways of accessing B-fields in Python code. In order to avoid hacks, this commit adds the necessary bindings to allow us to cleanly access B-fields with cache objects.

As acts-project#3479 reveals, we don't currently have any clean, cache-aware ways of
accessing B-fields in Python code. In order to avoid hacks, this commit
adds the necessary bindings to allow us to cleanly access B-fields with
cache objects.
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Aug 26, 2024
Copy link

github-actions bot commented Aug 26, 2024

📊: Physics performance monitoring for 3fc962a

Full contents

physmon summary

@paulgessinger paulgessinger added this to the next milestone Aug 26, 2024
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally hesitant to add too much of the Core lib to python, but I prefer this over the alternative I think. So let's do it.

Copy link

sonarcloud bot commented Aug 27, 2024

@kodiakhq kodiakhq bot merged commit a04b130 into acts-project:main Aug 27, 2024
42 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 27, 2024
@andiwand andiwand modified the milestones: next, v36.3.0 Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants