-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow Core CKF to skip the start surface #3535
Merged
kodiakhq
merged 10 commits into
acts-project:main
from
andiwand:feat-ckf-allow-skip-first-surface
Aug 30, 2024
Merged
feat: Allow Core CKF to skip the start surface #3535
kodiakhq
merged 10 commits into
acts-project:main
from
andiwand:feat-ckf-allow-skip-first-surface
Aug 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Track Finding
labels
Aug 22, 2024
github-actions
bot
added
Infrastructure
Changes to build tools, continous integration, ...
Changes Performance
labels
Aug 30, 2024
benjaminhuth
previously approved these changes
Aug 30, 2024
This PR currently has a merge conflict. Please resolve this and then re-add the |
benjaminhuth
approved these changes
Aug 30, 2024
Quality Gate passedIssues Measures |
acts-project-service
added
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Aug 30, 2024
andiwand
removed
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes Performance
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Infrastructure
Changes to build tools, continous integration, ...
Track Finding
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the user to skip the first surface during track finding with the CKF. This is necessary if the surface was already processed with a different pass, i.e. forward and backward, to avoid feeding the same measurement twice.