Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow Core CKF to skip the start surface #3535

Merged
merged 10 commits into from
Aug 30, 2024

Conversation

andiwand
Copy link
Contributor

Allows the user to skip the first surface during track finding with the CKF. This is necessary if the surface was already processed with a different pass, i.e. forward and backward, to avoid feeding the same measurement twice.

@andiwand andiwand added this to the next milestone Aug 22, 2024
@andiwand
Copy link
Contributor Author

cc @pbutti @paulgessinger

@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Track Finding labels Aug 22, 2024
Copy link

github-actions bot commented Aug 22, 2024

📊: Physics performance monitoring for 0d5311a

Full contents

physmon summary

@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Changes Performance labels Aug 30, 2024
@andiwand andiwand marked this pull request as ready for review August 30, 2024 07:41
benjaminhuth
benjaminhuth previously approved these changes Aug 30, 2024
@kodiakhq kodiakhq bot removed the automerge label Aug 30, 2024
Copy link
Contributor

kodiakhq bot commented Aug 30, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@andiwand andiwand marked this pull request as ready for review August 30, 2024 14:35
Copy link

sonarcloud bot commented Aug 30, 2024

@kodiakhq kodiakhq bot merged commit c231382 into acts-project:main Aug 30, 2024
42 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 30, 2024
@andiwand andiwand deleted the feat-ckf-allow-skip-first-surface branch August 31, 2024 00:32
@andiwand andiwand removed the Fails Athena tests This PR causes a failure in the Athena tests label Aug 31, 2024
@andiwand andiwand modified the milestones: next, v36.3.0 Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Component - Core Affects the Core module Component - Examples Affects the Examples module Infrastructure Changes to build tools, continous integration, ... Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants