Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Some refactorings around the G4 simulation #3532

Merged

Conversation

benjaminhuth
Copy link
Member

@benjaminhuth benjaminhuth commented Aug 21, 2024

These small fixes and refactorings came up during setup of the G4 simulation for geomodel geometries.

  • Add possibility to load hits into runTruthTrackingKalman function
  • conditional import of DD4hep in one place
  • Some changes to logging and errors/exceptions

@benjaminhuth benjaminhuth added this to the next milestone Aug 21, 2024
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Aug 21, 2024
Copy link

github-actions bot commented Aug 21, 2024

📊: Physics performance monitoring for 4ceb4f4

Full contents

physmon summary

@benjaminhuth benjaminhuth marked this pull request as draft August 22, 2024 10:50
@benjaminhuth benjaminhuth marked this pull request as ready for review August 27, 2024 12:50
@benjaminhuth benjaminhuth changed the title fix: Several fixes and refactor for G4 simulation refactor: Some refactorings around the G4 simulation Aug 27, 2024
Copy link

sonarcloud bot commented Aug 28, 2024

@kodiakhq kodiakhq bot merged commit 342b038 into acts-project:main Aug 28, 2024
42 checks passed
@andiwand andiwand modified the milestones: next, v36.3.0 Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants