-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Some refactorings around the G4 simulation #3532
Merged
kodiakhq
merged 10 commits into
acts-project:main
from
benjaminhuth:fix/fixes-and-refactor-for-g4-geomodel
Aug 28, 2024
Merged
refactor: Some refactorings around the G4 simulation #3532
kodiakhq
merged 10 commits into
acts-project:main
from
benjaminhuth:fix/fixes-and-refactor-for-g4-geomodel
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
previously approved these changes
Aug 21, 2024
benjaminhuth
commented
Aug 27, 2024
benjaminhuth
changed the title
fix: Several fixes and refactor for G4 simulation
refactor: Some refactorings around the G4 simulation
Aug 27, 2024
andiwand
approved these changes
Aug 27, 2024
paulgessinger
approved these changes
Aug 27, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These small fixes and refactorings came up during setup of the G4 simulation for geomodel geometries.
runTruthTrackingKalman
function