-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Cleanup cmake options, fix detray plugin #3509
build: Cleanup cmake options, fix detray plugin #3509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
I wonder if a version increment of Eigen should be a breaking change... Though not explicitely mentioned in the versioning file, this is not something I would expect from a minor version change... Also, this should be listed in the PR description, or maybe even in the PR title, or maybe even in a separte PR? |
@benjaminhuth I believe we started implicitly requiring it when we switched to C++20 by default. |
- builtin boost is remove - extern sources set up to actually check hashes - detray sets up dfelibs (was removed) - traccc doesn't specify cmake minimum version - reorder options to be more readable - preset tries to enable everything in the build
45cf4a2
to
a973515
Compare
There's a lot of duplicated code from the JSON plugin in the detray plugin that I'm removing here
Plugins/Detray/include/Acts/Plugins/Detray/DetrayConversionHelper.hpp
Outdated
Show resolved
Hide resolved
Removed the traccc patch in favor of https://github.com/acts-project/traccc/releases/tag/v0.15.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Quality Gate passedIssues Measures |
- Remove `-Wno-unused-local-typedefs` - Add `-Wzero-as-null-pointer-constant`, `-Wold-style-cast` and `-Wnull-derefence` - Fix warnings caused by these flags - [x] This requires an update to ODD, since ODD triggers old-style cast warnings currently. - [x] Depends on acts-project/actsvg#80 to avoid warnings from ACTSVG Blocked by - #3509
Blocked by: