Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Cleanup cmake options, fix detray plugin #3509

Merged
merged 19 commits into from
Aug 15, 2024

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Aug 14, 2024

  • builtin boost is remove
  • extern sources set up to actually check hashes
  • detray sets up dfelibs (was removed)
  • fix ordering: algebra-plugins needs to go before detray
  • traccc doesn't specify cmake minimum version
  • reorder options to be more readable
  • preset tries to enable everything in the build
  • detray and covfie plugins are removed in favor of a single traccc plugin

Blocked by:

@paulgessinger paulgessinger added this to the next milestone Aug 14, 2024
@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins labels Aug 14, 2024
@paulgessinger paulgessinger requested review from andiwand, fredevb and stephenswat and removed request for fredevb August 14, 2024 12:34
andiwand
andiwand previously approved these changes Aug 14, 2024
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

Copy link

github-actions bot commented Aug 14, 2024

📊: Physics performance monitoring for ed8abc8

Full contents

physmon summary

@benjaminhuth
Copy link
Member

benjaminhuth commented Aug 14, 2024

I wonder if a version increment of Eigen should be a breaking change... Though not explicitely mentioned in the versioning file, this is not something I would expect from a minor version change...
Or did we implicitly already require Eigen 3.4.0?

Also, this should be listed in the PR description, or maybe even in the PR title, or maybe even in a separte PR?

@paulgessinger
Copy link
Member Author

@benjaminhuth I believe we started implicitly requiring it when we switched to C++20 by default.

@paulgessinger paulgessinger added the 🛑 blocked This item is blocked by another item label Aug 14, 2024
paulgessinger and others added 8 commits August 14, 2024 21:56
- builtin boost is remove
- extern sources set up to actually check hashes
- detray sets up dfelibs (was removed)
- traccc doesn't specify cmake minimum version
- reorder options to be more readable
- preset tries to enable everything in the build
@github-actions github-actions bot added the Component - Documentation Affects the documentation label Aug 14, 2024
There's a lot of duplicated code from the JSON plugin in the detray
plugin that I'm removing here
@github-actions github-actions bot added the Component - Fatras Affects the Fatras module label Aug 15, 2024
@paulgessinger paulgessinger changed the title build: Cleanup cmake options build: Cleanup cmake options, fix detray plugin Aug 15, 2024
@paulgessinger
Copy link
Member Author

Removed the traccc patch in favor of https://github.com/acts-project/traccc/releases/tag/v0.15.0
This should be good to go now @benjaminhuth.

Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulgessinger paulgessinger added automerge and removed 🛑 blocked This item is blocked by another item labels Aug 15, 2024
@kodiakhq kodiakhq bot merged commit df0ab36 into acts-project:main Aug 15, 2024
43 checks passed
Copy link

sonarcloud bot commented Aug 15, 2024

@paulgessinger paulgessinger deleted the build/plugins-options branch August 16, 2024 07:19
@paulgessinger paulgessinger modified the milestones: next, v36.1.0 Aug 19, 2024
kodiakhq bot pushed a commit that referenced this pull request Aug 20, 2024
- Remove `-Wno-unused-local-typedefs`
- Add `-Wzero-as-null-pointer-constant`, `-Wold-style-cast` and `-Wnull-derefence`
- Fix warnings caused by these flags

- [x] This requires an update to ODD, since ODD triggers old-style cast warnings currently.
- [x] Depends on acts-project/actsvg#80 to avoid warnings from ACTSVG

Blocked by
-  #3509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Documentation Affects the documentation Component - Examples Affects the Examples module Component - Fatras Affects the Fatras module Component - Plugins Affects one or more Plugins Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants