refactor: Split GainMatrixUpdater compilation

[paulgessinger]

Once again, our compilation memory usage is out of control, among others due to GainMatrixUpdater. This currently takes about 1.2G peak memory.

In this PR, I'm moving the function doing the heavy instantiation back into a header, but I'm suppressing the instantiation of the template via extern template.

Then, I have CMake generate .cpp files where each file instantiates one dimension. The linker ultimately resolves these separate template insantiations.

Now, this is a bit ugly, but it does reduce peak memory consumption to under 600M, at the cost of now having 6 instead of one compilation unit:

[   16.73M, max:   295.39M] [    1.63s] - Core/src/TrackFitting/GainMatrixUpdater.cpp
[   16.58M, max:   431.10M] [    2.95s] - build/Core/src/TrackFitting/GainMatrixUpdaterImpl1.cpp
[   16.58M, max:   456.64M] [    3.13s] - build/Core/src/TrackFitting/GainMatrixUpdaterImpl2.cpp
[   17.06M, max:   485.18M] [    3.40s] - build/Core/src/TrackFitting/GainMatrixUpdaterImpl3.cpp
[   16.86M, max:   456.70M] [    3.24s] - build/Core/src/TrackFitting/GainMatrixUpdaterImpl4.cpp
[   16.58M, max:   568.34M] [    4.37s] - build/Core/src/TrackFitting/GainMatrixUpdaterImpl5.cpp
[   16.73M, max:   537.15M] [    4.11s] - build/Core/src/TrackFitting/GainMatrixUpdaterImpl6.cpp

Not sure this is the way to go, but I wanted to suggest it.

[andiwand]

Since this cuts the memory consumption drastically I would definitely consider putting this in. One thing I wondered is if we want to move the templated visit measurement into a detail header and also the generated source files and then only include them in the GainMatrixUpdater.cpp

[paulgessinger]

@andiwand The generated source files are only in the build folder, not in the source folder at all. In terms of where exactly the template function is, I don't have a preference. We'd have to include it the .cpp file, but it doesn't matter where it is.

[andiwand]

Maybe we can just put it directly into the GainMatrixUpdater.cpp

[paulgessinger]

@andiwand And then include the .cpp file? Always feels weird to me.

[andiwand]

Right it really should be a header file. I would put it rather in detail to box the template and only show it to the source file. But it is only a slight preference on my side

[github-actions]

📊: Physics performance monitoring for 096a612

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Particles ttbar
• ✅ Vertices ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Truth tracking (GX2F)
• ✅ Particles fatras
• ✅ Particles geant4

[paulgessinger]

Done now @andiwand.

[sonarcloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
38.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[acts-project-service]

🔴 Athena integration test results [ea794f2]

🔴 Some tests have failed!

Please investigate the pipeline!

status	job	report
🟢	report_pull_request
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco
🟢	test_ActsDumpGeometryIdentifiers
🔴	test_ActsCheckObjectCountsCachedWorkflow
🔴	test_ActsCheckObjectCountsWorkflow
🟢	test_ActsEFTrackFit
🟢	test_ActsPersistifySeeds
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsAnalogueClustering
🟢	test_ActsWorkflowHeavyIons
🟢	test_ActsWorkflowFastTracking
🟢	test_ActsWorkflowCached
🟢	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsPersistifyEDM
🟢	test_ActsGSFRefitting
🟢	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🟢	test_ActsITkTest
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	run_unit_tests