-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove uses of std::enable_if
#3484
refactor: Remove uses of std::enable_if
#3484
Conversation
This was quite meditative. |
42cc2ad
to
019f2db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it.
- Can you remove the cases where function template arguments are no longer necessary?
- Can you move the
requires
clause behind the function name and argument list?
d072610
to
e8ad837
Compare
@paulgessinger this is now all requires-east (requires after the function name) and I removed all the unnecessary type aliases. |
361732f
to
af3b230
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff.
e371eeb
to
4784e31
Compare
With the move to C++20, we no longer need `std::enable_if` as we can use the much more elegant `requires` keyword. This commit swaps virtually all uses of `std::enable_if`, except those in the existing pre-C++20 concepts library.
Quality Gate passedIssues Measures |
With the move to C++20, we no longer need
std::enable_if
as we can use the much more elegantrequires
keyword. This commit swaps virtually all uses ofstd::enable_if
, except those in the existing pre-C++20 concepts library.