-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(geometry): Surface merging returns ordering #3468
Merged
kodiakhq
merged 10 commits into
acts-project:main
from
paulgessinger:refactor/surface-merging-2024-08-01
Aug 8, 2024
Merged
refactor(geometry): Surface merging returns ordering #3468
kodiakhq
merged 10 commits into
acts-project:main
from
paulgessinger:refactor/surface-merging-2024-08-01
Aug 8, 2024
Commits on Aug 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 30a9869 - Browse repository at this point
Copy the full SHA 30a9869View commit details -
feat(geometry): CylinderSurface merging supports external rotation
Basically, this makes it so that the resulting merged CylinderSurface always has average phi == 0, i.e. symmetric phi sector around the local x axis, without any extra phi shift. Equivalent update of DiscSurface still pending
Configuration menu - View commit details
-
Copy full SHA for 7181148 - Browse repository at this point
Copy the full SHA 7181148View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee631e3 - Browse repository at this point
Copy the full SHA ee631e3View commit details -
refactor(geometry): Remove geometry context from merging
This is not actually needed, because we require the surfaces to not have detector elements anyway, and in that case, the transform is local to the surface anyway (and not alignable)
Configuration menu - View commit details
-
Copy full SHA for 15ccaaf - Browse repository at this point
Copy the full SHA 15ccaafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7244144 - Browse repository at this point
Copy the full SHA 7244144View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45a196e - Browse repository at this point
Copy the full SHA 45a196eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 824d629 - Browse repository at this point
Copy the full SHA 824d629View commit details
Commits on Aug 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 361593c - Browse repository at this point
Copy the full SHA 361593cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ee2fd1 - Browse repository at this point
Copy the full SHA 9ee2fd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ba6d9b - Browse repository at this point
Copy the full SHA 7ba6d9bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.