Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(geometry): Surface merging returns ordering #3468

Merged

Commits on Aug 1, 2024

  1. Configuration menu
    Copy the full SHA
    30a9869 View commit details
    Browse the repository at this point in the history
  2. feat(geometry): CylinderSurface merging supports external rotation

    Basically, this makes it so that the resulting merged CylinderSurface
    always has average phi == 0, i.e. symmetric phi sector around the local
    x axis, without any extra phi shift.
    
    Equivalent update of DiscSurface still pending
    paulgessinger committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    7181148 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ee631e3 View commit details
    Browse the repository at this point in the history
  4. refactor(geometry): Remove geometry context from merging

    This is not actually needed, because we require the surfaces to not have
    detector elements anyway, and in that case, the transform is local to
    the surface anyway (and not alignable)
    paulgessinger committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    15ccaaf View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7244144 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    45a196e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    824d629 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. pr feedback

    paulgessinger committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    361593c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9ee2fd1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7ba6d9b View commit details
    Browse the repository at this point in the history