-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: splitting fill and update function #3465
feat: splitting fill and update function #3465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Nice change for the chained navigation!
Invalidated by push of e28cf8f
Quality Gate passedIssues Measures |
📊: Physics performance monitoring for 834805ephysmon summary
|
Can you be a bit more explicit in the PR title? This ends up as the commit message and changelog entry, and should encapsulate what's changed. |
@asalzburger I guess it went in without it now. I just want to raise awareness that the PR title should convey what's being done, which this one does not. This could be anything only looking at the title. |
Thi PR splits the
fill(...)
andupdate(...)
function orNavigationStateUpdators
of theGen2
geometry.This avoid uneccesary copying and multiple intersections in case of chained updaters.