Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: splitting fill and update function #3465

Merged
merged 6 commits into from
Aug 1, 2024

Conversation

asalzburger
Copy link
Contributor

Thi PR splits the fill(...) and update(...) function or NavigationStateUpdators of the Gen2 geometry.

This avoid uneccesary copying and multiple intersections in case of chained updaters.

@github-actions github-actions bot added the Component - Core Affects the Core module label Aug 1, 2024
@asalzburger asalzburger added this to the next milestone Aug 1, 2024
dimitra97
dimitra97 previously approved these changes Aug 1, 2024
Copy link
Contributor

@dimitra97 dimitra97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice change for the chained navigation!

Copy link

sonarcloud bot commented Aug 1, 2024

@paulgessinger
Copy link
Member

Can you be a bit more explicit in the PR title? This ends up as the commit message and changelog entry, and should encapsulate what's changed.

@kodiakhq kodiakhq bot merged commit 7eb13e8 into acts-project:main Aug 1, 2024
47 checks passed
@paulgessinger paulgessinger deleted the feat-gen2-split-fill-update branch August 1, 2024 13:20
@paulgessinger
Copy link
Member

paulgessinger commented Aug 1, 2024

Can you be a bit more explicit in the PR title? This ends up as the commit message and changelog entry, and should encapsulate what's changed.

@asalzburger I guess it went in without it now. I just want to raise awareness that the PR title should convey what's being done, which this one does not. This could be anything only looking at the title.

@github-actions github-actions bot removed the automerge label Aug 1, 2024
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [7eb13e8]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Aug 1, 2024
@paulgessinger paulgessinger modified the milestones: next, v36.1.0 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants