-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Use pre-commit for CI lint #3464
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
paulgessinger
commented
Aug 1, 2024
- Formatting C++ and Python files
- Check trailing whitespace
- Check consistent newlines
- Check YAML contents
- Formatting C++ and Python files - Check trailing whitespace - Check consistent newlines - CHeck YAML contents
github-actions
bot
added
the
Infrastructure
Changes to build tools, continous integration, ...
label
Aug 1, 2024
github-actions
bot
added
Component - Core
Affects the Core module
Component - Fatras
Affects the Fatras module
Component - Examples
Affects the Examples module
Component - Plugins
Affects one or more Plugins
Component - Documentation
Affects the documentation
Seeding
Track Finding
Ambiguity Resolution
labels
Aug 1, 2024
I'm planning to follow this up with a bump of clang-format to v18, and an introduction of cmake file formatting. |
andiwand
reviewed
Aug 7, 2024
andiwand
previously approved these changes
Aug 7, 2024
This PR currently has a merge conflict. Please resolve this and then re-add the |
# Conflicts: # thirdparty/traccc/CMakeLists.txt
@andiwand this had a conflict, which should be resolved now. |
andiwand
approved these changes
Aug 8, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Ambiguity Resolution
Component - Core
Affects the Core module
Component - Documentation
Affects the documentation
Component - Examples
Affects the Examples module
Component - Fatras
Affects the Fatras module
Component - Plugins
Affects one or more Plugins
Infrastructure
Changes to build tools, continous integration, ...
Seeding
Track Finding
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.