Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add displaced vertex generator #3446

Merged
merged 11 commits into from
Aug 24, 2024
Merged

feat: Add displaced vertex generator #3446

merged 11 commits into from
Aug 24, 2024

Conversation

AichaMattouhi
Copy link
Contributor

feat: add the "full_chain_odd_LRT" for genertaing displaced vertices

@github-actions github-actions bot added the Component - Examples Affects the Examples module label Jul 26, 2024
@paulgessinger paulgessinger marked this pull request as draft July 26, 2024 11:22
@andiwand
Copy link
Contributor

@AichaMattouhi I fear something went wrong with the project structure here

paulgessinger
paulgessinger reviewed Aug 22, 2024
View reviewed changes
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few last points, then we can get this in.

CMakeLists.txt Outdated Show resolved Hide resolved
Examples/Python/python/acts/examples/simulation.py Outdated Show resolved Hide resolved
Examples/Scripts/Python/full_chain_odd.py Outdated Show resolved Hide resolved
Examples/Scripts/Python/odd_output/timing.tsv Outdated Show resolved Hide resolved
@paulgessinger paulgessinger changed the title example of LRT feat: Add displaced vertex generator Aug 22, 2024
@paulgessinger paulgessinger added this to the next milestone Aug 22, 2024
@paulgessinger paulgessinger marked this pull request as ready for review August 22, 2024 14:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 22, 2024 •
edited
Loading

📊: Physics performance monitoring for 6683619

Full contents

physmon summary

paulgessinger
paulgessinger previously approved these changes Aug 24, 2024
View reviewed changes
@paulgessinger
Copy link
Member

@AichaMattouhi I invited you to the GitHub team for CI permissions, can you accept the invitation?

@paulgessinger paulgessinger merged commit 1c555f3 into acts-project:main Aug 24, 2024
25 of 38 checks passed
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [1c555f3]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Aug 24, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@paulgessinger paulgessinger modified the milestones: next, v36.2.0 Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delitez delitez delitez left review comments

@paulgessinger paulgessinger paulgessinger left review comments

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Component - Examples Affects the Examples module
Projects
None yet
Milestone
v36.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@AichaMattouhi @andiwand @paulgessinger @acts-project-service @delitez