Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Renavigation for Gen1 #3437

Merged
merged 33 commits into from
Aug 26, 2024
Merged

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Jul 24, 2024

In case we loose the boundary we have to renavigate. For this purpose I introduce a loop in the preStep call where the first iteration has the original behavior and the second one is used in case of renavigation.

Incorporates #3238 to avoid double handling of the renavigation.

blocked by

@andiwand andiwand added this to the next milestone Jul 24, 2024
@github-actions github-actions bot added the Component - Core Affects the Core module label Jul 24, 2024
Copy link

github-actions bot commented Jul 24, 2024

📊: Physics performance monitoring for a606e81

Full contents

physmon summary

@andiwand andiwand marked this pull request as ready for review August 6, 2024 16:42
@andiwand andiwand marked this pull request as draft August 7, 2024 07:45
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Aug 19, 2024
@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Changes Performance labels Aug 19, 2024
@andiwand andiwand marked this pull request as ready for review August 19, 2024 17:00
@kodiakhq kodiakhq bot removed the automerge label Aug 24, 2024
Copy link
Contributor

kodiakhq bot commented Aug 24, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

paulgessinger
paulgessinger previously approved these changes Aug 24, 2024
@paulgessinger
Copy link
Member

Physmon failure still seems to be there.

kodiakhq bot pushed a commit that referenced this pull request Aug 25, 2024
Adds `assert`s to the `Navigator` to be sure that we are on the surface we expect to be.

This came up in #3437 and I pulled this out to test it separately.
Copy link

sonarcloud bot commented Aug 26, 2024

Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kodiakhq kodiakhq bot merged commit cda0b99 into acts-project:main Aug 26, 2024
44 checks passed
@andiwand andiwand deleted the feat-gen1-renavigation branch August 26, 2024 09:47
@paulgessinger paulgessinger modified the milestones: next, v37.0.0 Aug 26, 2024
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Component - Core Affects the Core module Component - Examples Affects the Examples module Fails Athena tests This PR causes a failure in the Athena tests Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants