-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Renavigation for Gen1 #3437
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m:andiwand/acts into feat-gen1-renavigation
github-actions
bot
added
Infrastructure
Changes to build tools, continous integration, ...
Changes Performance
labels
Aug 19, 2024
This PR currently has a merge conflict. Please resolve this and then re-add the |
paulgessinger
previously approved these changes
Aug 24, 2024
Physmon failure still seems to be there. |
…o feat-gen1-renavigation
This reverts commit 634c7a8.
Quality Gate passedIssues Measures |
benjaminhuth
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
acts-project-service
added
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes Performance
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Fails Athena tests
This PR causes a failure in the Athena tests
Infrastructure
Changes to build tools, continous integration, ...
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case we loose the boundary we have to renavigate. For this purpose I introduce a loop in the
preStep
call where the first iteration has the original behavior and the second one is used in case of renavigation.Incorporates #3238 to avoid double handling of the renavigation.
blocked by