chore: Do not copy parameters without ref Surface in TrackProxy #3426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
andiwand
commented
Jul 23, 2024
This reverts commit 979fae7.
paulgessinger
changed the title
TrackProxy::copyFrom
paulgessinger
approved these changes
Jul 23, 2024
📊: Physics performance monitoring for 2890cadphysmon summary
|
paulgessinger
approved these changes
Jul 23, 2024
|
acts-project-service
added
the
Breaks Athena build
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
This method returns a *shallow copy* of the track: track states are not copied themselves, but the copied track points at the same track states as the source track. Blocked by: - #3426 Co-authored-by: Andreas Stefl <[email protected]>
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
After the refactoring of the measurement selector it is possible that we end up with no measurements after selection. That case was not handled by the Core CKF yet. The current solution carries some duplication with the other hole handling. I do not see a great way to unify them. Potentially a combination of source link accessor and track state creator could solve this. blocked by - #3426 - #3427 - #3428 - #3438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor tweak of the
TrackProxy::copyFrom.parametersandcovarianceare only meaningful if a reference surface is given.