-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Rework particles_selected
handling in Python Examples
#3423
Merged
kodiakhq
merged 1 commit into
acts-project:main
from
andiwand:ex-refactor-particles-selected
Jul 22, 2024
Merged
refactor: Rework particles_selected
handling in Python Examples
#3423
kodiakhq
merged 1 commit into
acts-project:main
from
andiwand:ex-refactor-particles-selected
Jul 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedIssues Measures |
📊: Physics performance monitoring for 7f16b42physmon summary
|
dimitra97
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
A truth vertex seeding implementation for the Examples framework. This can be used for studying vertexing performance in case of optimal vertex seeding. This `TruthVertexSeeder` will return the truth vertex locations in the same order as they were generated. A potential future enhancement could be to reorder them or drop some of them depending on location and track content. blocked by - #3368 - #3421 - #3423
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small rework of the
particles_selected
handling in Python. I create dedicated whiteboard entries for the different simulators and then alias them toparticles_selected
. This allows for reassignment ofparticles_selected
later and moves the alias also to the post selection after simulation