Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rework particles_selected handling in Python Examples #3423

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

andiwand
Copy link
Contributor

Small rework of the particles_selected handling in Python. I create dedicated whiteboard entries for the different simulators and then alias them to particles_selected. This allows for reassignment of particles_selected later and moves the alias also to the post selection after simulation

@andiwand andiwand added this to the next milestone Jul 22, 2024
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Jul 22, 2024
Copy link

sonarcloud bot commented Jul 22, 2024

Copy link
Contributor

@dimitra97 dimitra97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@kodiakhq kodiakhq bot merged commit 1c0b1c5 into acts-project:main Jul 22, 2024
47 checks passed
@andiwand andiwand deleted the ex-refactor-particles-selected branch July 22, 2024 14:42
kodiakhq bot pushed a commit that referenced this pull request Jul 24, 2024
A truth vertex seeding implementation for the Examples framework. This can be used for studying vertexing performance in case of optimal vertex seeding. This `TruthVertexSeeder` will return the truth vertex locations in the same order as they were generated. A potential future enhancement could be to reorder them or drop some of them depending on location and track content.

blocked by
- #3368
- #3421
- #3423
@paulgessinger paulgessinger modified the milestones: next, v36.1.0 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants