Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Load linkcheck ignore patterns from URL #3400

Merged
merged 1 commit into from
Jul 17, 2024
Merged

docs: Load linkcheck ignore patterns from URL #3400

merged 1 commit into from
Jul 17, 2024

Conversation

paulgessinger
Copy link
Member

This allows us to fix this without creating pull-requests every time anything goes down.

@paulgessinger
docs: Load linkcheck ignore patterns from URL
f47c757 
This allows us to fix this without creating pull-requests every time
anything goes down.
@paulgessinger paulgessinger added this to the v36.0.0 milestone Jul 17, 2024
andiwand
andiwand approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

AJPfleger
AJPfleger approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can also add the comments in the other file, to keep track, why links were added.

@github-actions github-actions bot added the Component - Documentation Affects the documentation label Jul 17, 2024
@paulgessinger
Copy link
Member Author

@AJPfleger JSON does not support comments at all. We'd have to implement some custom parsing, which I'm not super inclined to do to be honest.

@paulgessinger paulgessinger merged commit 614633e into acts-project:main Jul 17, 2024
27 of 37 checks passed
@paulgessinger paulgessinger deleted the docs-linkcheck branch July 17, 2024 13:03
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [614633e]

🔴 Some tests have failed!

Please investigate the pipeline!

status job report
🔴 run_unit_tests
🟢 report_pull_request
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco
🟢 test_ActsDumpGeometryIdentifiers
🟢 test_ActsCheckObjectCountsWorkflow
🔴 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🟢 test_ActsBenchmarkWithSpot
🟢 test_ActsAnalogueClustering
🟢 test_ActsWorkflowHeavyIons
🟢 test_ActsWorkflowFastTracking
🔴 test_ActsWorkflowCached
🔴 test_ActsWorkflow
🔴 test_ActsValidateAmbiguityResolution
🟢 test_ActsValidateResolvedTracks
🟢 test_ActsValidateTracks
🔴 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🔴 test_ActsValidateSeeds
🔴 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🔴 test_ActsPersistifyEDM
🟢 test_ActsGSFRefitting
🟢 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest
🔴 run_workflow_tests_run4_mc
🔴 run_workflow_tests_run2_mc
🔴 run_workflow_tests_run2_data
🔴 run_workflow_tests_run3_mc
🔴 run_workflow_tests_run3_data

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJPfleger AJPfleger AJPfleger approved these changes

@andiwand andiwand andiwand approved these changes

Assignees
No one assigned
Labels
Component - Documentation Affects the documentation Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Milestone
v36.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@paulgessinger @acts-project-service @andiwand @AJPfleger