Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Remove redundant variables from Seed filter state #3393

Merged
merged 5 commits into from
Jul 18, 2024
Merged

refactor!: Remove redundant variables from Seed filter state #3393

merged 5 commits into from
Jul 18, 2024

Conversation

CarloVarni
Copy link
Collaborator

The number of seeds (high and low quality) is already stored inside another class. They can be removed from the seed filter state.

No change is expected due to this in the seeding performance

@CarloVarni CarloVarni added this to the next milestone Jul 16, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Documentation Affects the documentation Seeding labels Jul 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 16, 2024 •
edited
Loading

📊: Physics performance monitoring for 423ed90

Full contents

physmon summary

@CarloVarni CarloVarni modified the milestones: next, v36.0.0 Jul 17, 2024
@CarloVarni CarloVarni requested a review from andiwand July 18, 2024 07:10
andiwand
andiwand approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @LuisFelipeCoelho do you want to have a look too?

@CarloVarni CarloVarni mentioned this pull request Jul 18, 2024
Merged
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 25%)
0.0% Line Coverage on New Code (required ≥ 50%)

See analysis details on SonarCloud

@paulgessinger paulgessinger merged commit 05e7f82 into acts-project:main Jul 18, 2024
28 of 40 checks passed
@CarloVarni CarloVarni deleted the SeedFilter branch July 18, 2024 15:14
@acts-project-service
Copy link
Collaborator

acts-project-service commented Jul 18, 2024 •
edited
Loading

🔴 Athena integration test results [05e7f82]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Jul 18, 2024
kodiakhq bot pushed a commit that referenced this pull request Jul 23, 2024
@CarloVarni
ci: Add unit test seed filter objects -- part 1 (#3402)
ac84a99 
Adding some unit test for some objects used in the seed finding process

requires:
-  #3393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andiwand andiwand andiwand approved these changes

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module Component - Documentation Affects the documentation Seeding
Projects
None yet
Milestone
v36.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@CarloVarni @acts-project-service @andiwand @paulgessinger