Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop IWYU #3390

Merged
merged 3 commits into from
Jul 16, 2024
Merged

chore: Drop IWYU #3390

merged 3 commits into from
Jul 16, 2024

Conversation

andiwand
Copy link
Contributor

This does not seem reliable enough to have it as a continuous workflow and the manual work is also significant to apply the fixes.

@andiwand andiwand added this to the next milestone Jul 15, 2024
@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label Jul 15, 2024
paulgessinger
paulgessinger previously approved these changes Jul 15, 2024
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to do this again based on clang-tidy, which I think has added this functionality somewhat recently and might be more robust.

Copy link
Contributor

kodiakhq bot commented Jul 15, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

Copy link

sonarcloud bot commented Jul 16, 2024

@kodiakhq kodiakhq bot merged commit 8890c18 into acts-project:main Jul 16, 2024
44 checks passed
@andiwand andiwand deleted the nuke-iwyu branch July 16, 2024 11:35
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [8890c18]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Jul 16, 2024
@paulgessinger paulgessinger modified the milestones: next, v36.0.0 Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants