-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Clean includes in Geant4Manager
#3362
Merged
kodiakhq
merged 3 commits into
acts-project:main
from
andiwand:fix-ex-g4-clean-includes
Jul 10, 2024
Merged
fix: Clean includes in Geant4Manager
#3362
kodiakhq
merged 3 commits into
acts-project:main
from
andiwand:fix-ex-g4-clean-includes
Jul 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @wdconinc |
📊: Physics performance monitoring for 7cfd1c8physmon summary
|
paulgessinger
approved these changes
Jul 10, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it was reported in the ACTS developers meeting
G4Profiler.hh
is gone in Geant4 11.3. For some reason this ended up inGeant4Manager.cpp
even though we do not use it. Here the include is removed which should allow to build ACTS against the new Geant4 version.