Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add compatibility for PODIO 1.x #3360

Merged
merged 8 commits into from
Jul 11, 2024
Merged

feat: Add compatibility for PODIO 1.x #3360

merged 8 commits into from
Jul 11, 2024

Conversation

paulgessinger
Copy link
Member

This adds the ability to compile with PODIO 1.x. We retain compatibility with 0.17.x for now, using preprocessor gates.

@paulgessinger paulgessinger added this to the v36.0.0 milestone Jul 9, 2024
@paulgessinger paulgessinger marked this pull request as draft July 9, 2024 14:37
@github-actions github-actions bot added Component - Plugins Affects one or more Plugins Component - Examples Affects the Examples module labels Jul 9, 2024
@paulgessinger paulgessinger marked this pull request as ready for review July 10, 2024 16:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 11, 2024 •
edited
Loading

📊: Physics performance monitoring for 2d09e75

Full contents

physmon summary

pbutti
pbutti approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@pbutti pbutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kodiakhq kodiakhq bot merged commit 9b51fed into acts-project:main Jul 11, 2024
49 checks passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
60.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@acts-project-service
Copy link
Collaborator

acts-project-service commented Jul 11, 2024 •
edited
Loading

🔴 Athena integration test results [9b51fed]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbutti pbutti pbutti approved these changes

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins
Projects
None yet
Milestone
v36.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@paulgessinger @acts-project-service @pbutti