Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add nCleanVtx to VertexPerformanceWriter in Examples #3352

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Jul 6, 2024

Somehow this was missing but is very handy compared to counting the occurrences in recoVertexClassification

AJPfleger
AJPfleger previously approved these changes Jul 8, 2024
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulgessinger
Copy link
Member

Are the physmon changes due to new histograms? Can you update the reference files.

@andiwand
Copy link
Contributor Author

andiwand commented Jul 9, 2024

yes - I will bump the ref files

@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Changes Performance labels Jul 9, 2024
Copy link

sonarcloud bot commented Jul 9, 2024

Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kodiakhq kodiakhq bot merged commit abebe1f into acts-project:main Jul 9, 2024
52 checks passed
@github-actions github-actions bot removed the automerge label Jul 9, 2024
@andiwand andiwand deleted the ex-feat-vtxperf-ncleanvtx branch July 9, 2024 09:28
@paulgessinger paulgessinger modified the milestones: next, v36.0.0 Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Component - Examples Affects the Examples module Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants