Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add GeoModel Plugin to CI #3327

Merged
merged 19 commits into from
Jul 10, 2024
Merged

ci: Add GeoModel Plugin to CI #3327

merged 19 commits into from
Jul 10, 2024

Conversation

benjaminhuth
Copy link
Member

I think the GeoModel plugin is not built in the CI currently, so this is changed with this PR. Contains a bit of cmake analysis additionally.

@benjaminhuth benjaminhuth added this to the next milestone Jun 24, 2024
@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Component - Plugins Affects one or more Plugins labels Jun 24, 2024
paulgessinger
paulgessinger previously approved these changes Jun 25, 2024
.github/workflows/builds.yml Show resolved Hide resolved
@paulgessinger
Copy link
Member

There's still a problem in the CI. Also, can you avoid using the upstream repository for feature branches? This is not a huge problem, but it keeps the CI jobs separated between forks and upstream.

@benjaminhuth
Copy link
Member Author

Yeah, this was a mistake, I started the PR directly from github ui, and didn't noticed the repo... I usually don't do that

@benjaminhuth benjaminhuth marked this pull request as draft June 26, 2024 06:39
@asalzburger asalzburger mentioned this pull request Jul 5, 2024
kodiakhq bot pushed a commit that referenced this pull request Jul 5, 2024
This PR fixes the GeoModel plugin after changes to the `BinningType`.
It should make #3327 work again.
@benjaminhuth benjaminhuth marked this pull request as ready for review July 6, 2024 13:24
Copy link

sonarcloud bot commented Jul 9, 2024

@paulgessinger paulgessinger merged commit 0413241 into main Jul 10, 2024
74 checks passed
@paulgessinger paulgessinger deleted the ci/add-geomodel-to-ci branch July 10, 2024 11:53
@acts-project-service
Copy link
Collaborator

acts-project-service commented Jul 10, 2024

🔴 Athena integration test results [0413241]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added Fails Athena tests This PR causes a failure in the Athena tests Breaks Athena build This PR breaks the Athena build labels Jul 10, 2024
Berggren-Jonas pushed a commit to Berggren-Jonas/acts that referenced this pull request Jul 12, 2024
This PR fixes the GeoModel plugin after changes to the `BinningType`.
It should make acts-project#3327 work again.
@paulgessinger paulgessinger modified the milestones: next, v36.0.0 Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Plugins Affects one or more Plugins Fails Athena tests This PR causes a failure in the Athena tests Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants