test: use ACTS logging for Navigator tests

[AJPfleger]

blocked by:

• test: reduce navigator tests with TryAll as reference #3311
• test: Move Navigator consistency checks to integration tests #3315

[github-actions]

📊: Physics performance monitoring for a9ce03c

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Truth tracking (GX2F)
• ✅ Particles fatras
• ✅ Particles geant4

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.31%. Comparing base (cf9d872) to head (75df02b).
Report is 11 commits behind head on main.

❗ Current head 75df02b differs from pull request most recent head a9ce03c

Please upload reports for the commit a9ce03c to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3312      +/-   ##
==========================================
+ Coverage   47.24%   47.31%   +0.07%     
==========================================
  Files         508      512       +4     
  Lines       30041    30441     +400     
  Branches    14586    14795     +209     
==========================================
+ Hits        14192    14404     +212     
- Misses       5375     5404      +29     
- Partials    10474    10633     +159     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[andiwand]

I think it is not strictly necessary to use logger in our tests over cout. I see the logger interface more as an opportunity for the client to overwrite the logging behavior. It does not hurt to adopt this but it would be a big amount of work to replace all the couts in our tests consistently and I don't see a big benefit from this.

[AJPfleger]

It's probably not necessary, since we don't evoke our test suite with different logging levels and therefore need to recompile anyhow when we want to have more or less output.

However, I changed it, after going through the test and I understood, that the variables debug and debugMode are added scattered over the test with the only purpose of toggling de couts.
I expect to benefit from this change, when I want to revisit these tests and don't need to figure out, that those 2 variables are just enabling a verbose version of an existing function.

[andiwand]

👍

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[acts-project-service]

✅ Athena integration test results

✅ All tests successful

status	job	report
🟢	run_unit_tests
🟢	test_ActsDumpGeometryIdentifiers
🟢	test_ActsCheckObjectCountsWorkflow
🟢	test_ActsEFTrackFit
🟢	test_ActsPersistifySeeds
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsAnalogueClustering
🟢	test_ActsWorkflowHeavyIons
🟢	test_ActsWorkflowFastTracking
🟢	test_ActsWorkflowCached
🟢	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsPersistifyEDM
🟢	test_ActsGSFRefitting
🟢	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🟢	test_ActsITkTest
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco