Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace legacy limits with std::numeric_limits or similar for consistency #3298

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

AJPfleger
Copy link
Contributor

No description provided.

@AJPfleger AJPfleger added this to the next milestone Jun 16, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Fatras Affects the Fatras module Component - Examples Affects the Examples module Component - Documentation Affects the documentation Track Fitting labels Jun 16, 2024
Copy link

codecov bot commented Jun 16, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.31%. Comparing base (7e1e819) to head (9ab6226).
Report is 265 commits behind head on main.

Files with missing lines Patch % Lines
Core/include/Acts/Surfaces/BoundaryCheck.hpp 33.33% 0 Missing and 2 partials ⚠️
Core/include/Acts/TrackFitting/KalmanFitter.hpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3298   +/-   ##
=======================================
  Coverage   47.31%   47.31%           
=======================================
  Files         512      512           
  Lines       30437    30440    +3     
  Branches    14795    14795           
=======================================
+ Hits        14400    14403    +3     
  Misses       5404     5404           
  Partials    10633    10633           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

@kodiakhq kodiakhq bot merged commit eb8848f into acts-project:main Jun 17, 2024
53 checks passed
@AJPfleger AJPfleger deleted the cstddef branch June 17, 2024 14:02
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Jun 17, 2024
Matthewharri pushed a commit to Matthewharri/acts that referenced this pull request Jun 18, 2024
timadye pushed a commit to andiwand/acts that referenced this pull request Jun 27, 2024
@paulgessinger paulgessinger modified the milestones: next, v36.0.0 Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Documentation Affects the documentation Component - Examples Affects the Examples module Component - Fatras Affects the Fatras module Fails Athena tests This PR causes a failure in the Athena tests Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants