-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Resolve surfaces on initialization in Navigator
#3283
Merged
kodiakhq
merged 8 commits into
acts-project:main
from
andiwand:refactor-navigator-resolve-surfaces-on-initialization
Jul 25, 2024
Merged
refactor: Resolve surfaces on initialization in Navigator
#3283
kodiakhq
merged 8 commits into
acts-project:main
from
andiwand:refactor-navigator-resolve-surfaces-on-initialization
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igator-resolve-surfaces-on-initialization
…igator-resolve-surfaces-on-initialization
📊: Physics performance monitoring for e236c7ephysmon summary
|
github-actions
bot
added
Component - Examples
Affects the Examples module
Changes Performance
labels
Jul 24, 2024
noemina
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense and look good to me.
Quality Gate passedIssues Measures |
acts-project-service
added
the
Breaks Athena build
This PR breaks the Athena build
label
Jul 25, 2024
andiwand
deleted the
refactor-navigator-resolve-surfaces-on-initialization
branch
July 25, 2024 18:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaks Athena build
This PR breaks the Athena build
Changes Performance
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going a bit further than #3280 by removing the status flag for the start layer resolution and resolving the surfaces already in the initialization step.
blocked by