Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Resolve surfaces on initialization in Navigator #3283

Conversation

andiwand
Copy link
Contributor

Going a bit further than #3280 by removing the status flag for the start layer resolution and resolving the surfaces already in the initialization step.

blocked by

@andiwand andiwand added the 🛑 blocked This item is blocked by another item label Jun 13, 2024
@andiwand andiwand added this to the next milestone Jun 13, 2024
@andiwand
Copy link
Contributor Author

cc @benjaminhuth

@github-actions github-actions bot added Component - Core Affects the Core module labels Jun 13, 2024
@github-actions github-actions bot added the Stale label Jul 13, 2024
@andiwand andiwand removed Stale 🛑 blocked This item is blocked by another item labels Jul 23, 2024
@andiwand andiwand marked this pull request as ready for review July 24, 2024 11:14
@andiwand
Copy link
Contributor Author

seems not to effect CPU performance while physmon suggests a small increase in efficiency for the CKF

image

image

@github-actions github-actions bot added Component - Examples Affects the Examples module Changes Performance labels Jul 24, 2024
Copy link
Contributor

@noemina noemina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense and look good to me.

Copy link

sonarcloud bot commented Jul 25, 2024

@kodiakhq kodiakhq bot merged commit b58a4b4 into acts-project:main Jul 25, 2024
46 checks passed
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [b58a4b4]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Jul 25, 2024
@andiwand andiwand deleted the refactor-navigator-resolve-surfaces-on-initialization branch July 25, 2024 18:06
@paulgessinger paulgessinger removed this from the next milestone Aug 19, 2024
@paulgessinger paulgessinger added this to the v36.1.0 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Changes Performance Component - Core Affects the Core module Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants