-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: (gx2f) generalise ndf calculation for error NotEnoughMeasurements
#3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊: Physics performance monitoring for fb54cfbphysmon summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3278 +/- ##
=======================================
Coverage 47.37% 47.37%
=======================================
Files 511 511
Lines 30249 30254 +5
Branches 14677 14679 +2
=======================================
+ Hits 14329 14333 +4
+ Misses 5386 5383 -3
- Partials 10534 10538 +4 ☔ View full report in Codecov by Sentry. |
andiwand
reviewed
Jun 13, 2024
andiwand
requested changes
Jun 13, 2024
andiwand
approved these changes
Jun 13, 2024
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jun 14, 2024
…ents` (acts-project#3278) This handles a few edge cases, when we had just enough measurements for a straight line fit.
I don't think this should be flagged as breaking as it is not part of the versioned API |
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
…ents` (acts-project#3278) This handles a few edge cases, when we had just enough measurements for a straight line fit.
timadye
pushed a commit
to andiwand/acts
that referenced
this pull request
Jun 27, 2024
…ents` (acts-project#3278) This handles a few edge cases, when we had just enough measurements for a straight line fit.
AJPfleger
changed the title
feat!: (gx2f) generalise ndf calcualtion for error
feat!: (gx2f) generalise ndf calculation for error Sep 27, 2024
NotEnoughMeasurements
NotEnoughMeasurements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles a few edge cases, when we had just enough measurements for a straight line fit.