Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: (gx2f) generalise ndf calculation for error NotEnoughMeasurements #3278

Merged
merged 9 commits into from
Jun 13, 2024

Conversation

AJPfleger
Copy link
Contributor

This handles a few edge cases, when we had just enough measurements for a straight line fit.

@AJPfleger AJPfleger added this to the next milestone Jun 12, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Track Fitting labels Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 47.37%. Comparing base (e497338) to head (fb54cfb).
Report is 274 commits behind head on main.

Files with missing lines Patch % Lines
...nclude/Acts/TrackFitting/GlobalChiSquareFitter.hpp 60.00% 1 Missing and 3 partials ⚠️
Core/src/TrackFitting/GlobalChiSquareFitter.cpp 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3278   +/-   ##
=======================================
  Coverage   47.37%   47.37%           
=======================================
  Files         511      511           
  Lines       30249    30254    +5     
  Branches    14677    14679    +2     
=======================================
+ Hits        14329    14333    +4     
+ Misses       5386     5383    -3     
- Partials    10534    10538    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AJPfleger AJPfleger requested a review from andiwand June 13, 2024 05:55
@AJPfleger AJPfleger requested a review from andiwand June 13, 2024 08:35
@kodiakhq kodiakhq bot merged commit dda478e into acts-project:main Jun 13, 2024
53 checks passed
@AJPfleger AJPfleger deleted the ndf-general branch June 13, 2024 12:44
paulgessinger pushed a commit to paulgessinger/acts that referenced this pull request Jun 14, 2024
…ents` (acts-project#3278)

This handles a few edge cases, when we had just enough measurements for a straight line fit.
@andiwand andiwand modified the milestones: next, v35.2.0 Jun 16, 2024
@andiwand
Copy link
Contributor

I don't think this should be flagged as breaking as it is not part of the versioned API

Matthewharri pushed a commit to Matthewharri/acts that referenced this pull request Jun 18, 2024
…ents` (acts-project#3278)

This handles a few edge cases, when we had just enough measurements for a straight line fit.
timadye pushed a commit to andiwand/acts that referenced this pull request Jun 27, 2024
…ents` (acts-project#3278)

This handles a few edge cases, when we had just enough measurements for a straight line fit.
@AJPfleger AJPfleger changed the title feat!: (gx2f) generalise ndf calcualtion for error NotEnoughMeasurements feat!: (gx2f) generalise ndf calculation for error NotEnoughMeasurements Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants