Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add some missing headers for GCC 14 #3259

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

benjaminhuth
Copy link
Member

These headers need to be included to build with GCC 14. Additional fixed a unused variable warning.

@benjaminhuth benjaminhuth added the Bug Something isn't working label Jun 6, 2024
@benjaminhuth benjaminhuth added this to the next milestone Jun 6, 2024
@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.65%. Comparing base (ead5ef4) to head (339a332).
Report is 278 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3259   +/-   ##
=======================================
  Coverage   47.65%   47.65%           
=======================================
  Files         507      507           
  Lines       29205    29205           
  Branches    14011    14011           
=======================================
  Hits        13918    13918           
  Misses       5263     5263           
  Partials    10024    10024           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 4e4d2ca into acts-project:main Jun 7, 2024
51 checks passed
@github-actions github-actions bot removed the automerge label Jun 7, 2024
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Jun 7, 2024
@andiwand andiwand modified the milestones: next, v35.2.0 Jun 16, 2024
Matthewharri pushed a commit to Matthewharri/acts that referenced this pull request Jun 18, 2024
These headers need to be included to build with GCC 14. Additional fixed a unused variable warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Component - Plugins Affects one or more Plugins Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants