-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(coverage): add token + temporarily increase threshold #3222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Infrastructure
Changes to build tools, continous integration, ...
label
May 24, 2024
📊: Physics performance monitoring for 6c7b9ddphysmon summary
|
AJPfleger
changed the title
ci(coverage): temporarily increasing change threshold
ci(coverage): add token + temporarily increase threshold
May 24, 2024
andiwand
approved these changes
May 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3222 +/- ##
==========================================
- Coverage 49.14% 47.51% -1.63%
==========================================
Files 499 499
Lines 29253 28292 -961
Branches 13870 13832 -38
==========================================
- Hits 14375 13442 -933
- Misses 4969 4970 +1
+ Partials 9909 9880 -29 ☔ View full report in Codecov by Sentry. |
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 31, 2024
…t#3222) Follow up to `https://github.com/acts-project/acts/pull/3215`. The base did not get uploaded to codecov. Therefore, the difference-problem is handed over to the next PR. We need to provide the token to successfully upload. We increase the accepted threshold to update the codecov-BASE over the course of 2 PRs, to get PRs (including this one) in until the upload problem is solved.
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 31, 2024
) Resets the codecov threshold after: - acts-project#3222
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
…t#3222) Follow up to `https://github.com/acts-project/acts/pull/3215`. The base did not get uploaded to codecov. Therefore, the difference-problem is handed over to the next PR. We need to provide the token to successfully upload. We increase the accepted threshold to update the codecov-BASE over the course of 2 PRs, to get PRs (including this one) in until the upload problem is solved.
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
) Resets the codecov threshold after: - acts-project#3222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to:
The base did not get uploaded to codecov. Therefore, the difference-problem is handed over to the next PR. We need to provide the token to successfully upload. We increase the accepted threshold to update the codecov-BASE over the course of 2 PRs, to get PRs (including this one) in until the upload problem is solved.
The threshold will be reset in: