Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use double for CylinderBounds::inside #3210

Merged
merged 6 commits into from
May 23, 2024

Conversation

andiwand
Copy link
Contributor

Popped up here #3207 (comment)

I think this can be safely changed to a double

@andiwand andiwand added this to the next milestone May 23, 2024
@github-actions github-actions bot added the Component - Core Affects the Core module label May 23, 2024
@andiwand andiwand changed the title refactor: Use double for CylinderBounds::inside refactor: Use double for CylinderBounds::inside May 23, 2024
@AJPfleger AJPfleger self-requested a review May 23, 2024 07:46
@kodiakhq kodiakhq bot merged commit 273278b into acts-project:main May 23, 2024
50 checks passed
@andiwand andiwand deleted the cylinder-bounds-inside-double branch May 23, 2024 18:56
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 31, 2024
Popped up here acts-project#3207 (comment)

I think this can be safely changed to a `double`
@andiwand andiwand modified the milestones: next, v35.1.0 Jun 1, 2024
Matthewharri pushed a commit to Matthewharri/acts that referenced this pull request Jun 18, 2024
Popped up here acts-project#3207 (comment)

I think this can be safely changed to a `double`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants