fix: Fix Core CKF segfault with fitted params #3203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊: Physics performance monitoring for cc16461physmon summary
|
AJPfleger
reviewed
May 22, 2024
AJPfleger
approved these changes
May 22, 2024
acts-project-service
added
the
Fails Athena tests
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 31, 2024
This fixes a rare bug in the CKF. During extrapolation to the target surface we expect a previous track state which does not need to exist necessarily. acts-project#3161 also cleans this up by having tracks for each branch instead of last tip states
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
This fixes a rare bug in the CKF. During extrapolation to the target surface we expect a previous track state which does not need to exist necessarily. acts-project#3161 also cleans this up by having tracks for each branch instead of last tip states
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
We would like to run part of our seeds for track finding in Athena first inwards and then outwards. First we wanted to showcase this using the Acts Examples framework. Since we do not really have multiple seed regions in the Examples right now this is modeled as a static config flag in the track finding. blocked by - #3203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a rare bug in the CKF. During extrapolation to the target surface we expect a previous track state which does not need to exist necessarily.
#3161 also cleans this up by having tracks for each branch instead of last tip states