refactor!: Refactor navigator options

[andiwand]

Move startSurface and targetSurface to Navigator::Options. In two followup PRs (#3189, #3183) the options will be extended by direct navigator surface and external surfaces.

blocked by:

• refactor!: Split propagator options #3181
• refactor: Simplify layer handling in Navigator #3190

[github-actions]

📊: Physics performance monitoring for c59f49a

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Particles ttbar
• ✅ Vertices ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Truth tracking (GX2F)
• ✅ Particles fatras
• ✅ Particles geant4

[codecov]

Codecov Report

Attention: Patch coverage is 71.54472% with 35 lines in your changes missing coverage. Please review.

Project coverage is 47.66%. Comparing base (75ef913) to head (e8fe116).
Report is 77 commits behind head on main.

Files	Patch %	Lines
...lude/Acts/Propagator/DenseEnvironmentExtension.hpp	0.00%	0 Missing and 6 partials ⚠️
Core/include/Acts/Propagator/DirectNavigator.hpp	72.22%	0 Missing and 5 partials ⚠️
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp	0.00%	4 Missing and 1 partial ⚠️
Core/include/Acts/TrackFitting/KalmanFitter.hpp	54.54%	0 Missing and 5 partials ⚠️
Core/include/Acts/Propagator/PropagatorOptions.hpp	83.33%	0 Missing and 3 partials ⚠️
Core/include/Acts/Propagator/PropagatorState.hpp	40.00%	0 Missing and 3 partials ⚠️
Core/include/Acts/Propagator/EigenStepper.ipp	50.00%	2 Missing ⚠️
Core/include/Acts/Propagator/AtlasStepper.hpp	50.00%	0 Missing and 1 partial ⚠️
Core/include/Acts/Propagator/Navigator.hpp	88.88%	0 Missing and 1 partial ⚠️
Core/include/Acts/Propagator/TryAllNavigator.hpp	85.71%	0 Missing and 1 partial ⚠️
... and 3 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3182      +/-   ##
==========================================
- Coverage   47.66%   47.66%   -0.01%     
==========================================
  Files         509      511       +2     
  Lines       29425    29425              
  Branches    14131    14133       +2     
==========================================
- Hits        14026    14025       -1     
+ Misses       5285     5282       -3     
- Partials    10114    10118       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[paulgessinger]

Without #3189, this is a bit odd, since it adds an extra struct and doesn't really do anything about the flow of information.

[sonarcloud]

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
41.6% Coverage on New Code
18.6% Duplication on New Code

See analysis details on SonarCloud

[acts-project-service]

✅ Athena integration test results [3b8ea13]

✅ All tests successful

status	job	report
🟢	report_pull_request
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco
🟢	test_ActsDumpGeometryIdentifiers
🟢	test_ActsCheckObjectCountsWorkflow
🟢	test_ActsEFTrackFit
🟢	test_ActsPersistifySeeds
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsAnalogueClustering
🟢	test_ActsWorkflowHeavyIons
🟢	test_ActsWorkflowFastTracking
🟢	test_ActsWorkflowCached
🟢	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsPersistifyEDM
🟢	test_ActsGSFRefitting
🟢	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🟢	test_ActsITkTest
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	run_unit_tests