-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Examples can run sim/digi on ODD with Gen1 and Gen2 geometry #3175
Merged
kodiakhq
merged 13 commits into
acts-project:main
from
asalzburger:feat-sim-digi-gen1-and-gen2
May 13, 2024
Merged
feat: Examples can run sim/digi on ODD with Gen1 and Gen2 geometry #3175
kodiakhq
merged 13 commits into
acts-project:main
from
asalzburger:feat-sim-digi-gen1-and-gen2
May 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
labels
May 7, 2024
AJPfleger
reviewed
May 7, 2024
Examples/Algorithms/Geant4/include/ActsExamples/Geant4/ParticleKillAction.hpp
Outdated
Show resolved
Hide resolved
…eKillAction.hpp Co-authored-by: Alexander J. Pfleger <[email protected]>
AJPfleger
previously approved these changes
May 7, 2024
📊: Physics performance monitoring for cb2d49dphysmon summary
|
andiwand
reviewed
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. I worry a little bit about the new naming of recoGeometry
Examples/Io/Root/include/ActsExamples/Io/Root/RootMeasurementWriter.hpp
Outdated
Show resolved
Hide resolved
Examples/Algorithms/Digitization/include/ActsExamples/Digitization/DigitizationConfig.hpp
Show resolved
Hide resolved
Co-authored-by: Andreas Stefl <[email protected]>
Co-authored-by: Andreas Stefl <[email protected]>
…riter.hpp Co-authored-by: Andreas Stefl <[email protected]>
…tion/DigitizationConfig.hpp Co-authored-by: Andreas Stefl <[email protected]>
Co-authored-by: Andreas Stefl <[email protected]>
AJPfleger
approved these changes
May 13, 2024
asalzburger
added a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…cts-project#3175) This PR allows to run simulation and digitisation (currently Geant4 for both, Fatras only for Gen1). The trick here is to make a `Union[acts.TrackingGeometry, acts.Detector]` and equip the python `acts.Detector` object with symmetries methods.
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
…cts-project#3175) This PR allows to run simulation and digitisation (currently Geant4 for both, Fatras only for Gen1). The trick here is to make a `Union[acts.TrackingGeometry, acts.Detector]` and equip the python `acts.Detector` object with symmetries methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to run simulation and digitisation (currently Geant4 for both, Fatras only for Gen1).
The trick here is to make a
Union[acts.TrackingGeometry, acts.Detector]
and equip the pythonacts.Detector
object with symmetries methods.