-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: binned surface material detray #3174
Merged
kodiakhq
merged 4 commits into
acts-project:main
from
asalzburger:feat-binned-surface-material-detray-cherry-pick
May 6, 2024
Merged
feat: binned surface material detray #3174
kodiakhq
merged 4 commits into
acts-project:main
from
asalzburger:feat-binned-surface-material-detray-cherry-pick
May 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Examples
Affects the Examples module
Component - Plugins
Affects one or more Plugins
labels
May 6, 2024
niermann999
reviewed
May 6, 2024
📊: Physics performance monitoring for 56b22c8physmon summary
|
niermann999
approved these changes
May 6, 2024
acts-project-service
added
Fails Athena tests
This PR causes a failure in the Athena tests
Breaks Athena build
This PR breaks the Athena build
labels
May 6, 2024
asalzburger
added a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
This PR adds the necessary json conversion to write out ACTS BinnedSurfaceMaterial to detray material maps (in json). The conversion now yields practically identical material in ACTS and detray: <img width="887" alt="Screenshot 2024-05-06 at 17 12 27" src="https://github.com/acts-project/acts/assets/26623879/088df5b9-c30d-4b1b-9e70-02a717311031">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaks Athena build
This PR breaks the Athena build
Component - Examples
Affects the Examples module
Component - Plugins
Affects one or more Plugins
Fails Athena tests
This PR causes a failure in the Athena tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the necessary json conversion to write out ACTS BinnedSurfaceMaterial to detray material maps (in json).
The conversion now yields practically identical material in ACTS and detray: