Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: binned surface material detray #3174

Conversation

asalzburger
Copy link
Contributor

This PR adds the necessary json conversion to write out ACTS BinnedSurfaceMaterial to detray material maps (in json).

The conversion now yields practically identical material in ACTS and detray:

Screenshot 2024-05-06 at 17 12 27

@github-actions github-actions bot added Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins labels May 6, 2024
@asalzburger asalzburger added this to the next milestone May 6, 2024
@kodiakhq kodiakhq bot merged commit 2e56da5 into acts-project:main May 6, 2024
53 checks passed
@github-actions github-actions bot removed the automerge label May 6, 2024
@acts-project-service acts-project-service added Fails Athena tests This PR causes a failure in the Athena tests Breaks Athena build This PR breaks the Athena build labels May 6, 2024
@andiwand andiwand modified the milestones: next, v35.0.0 May 17, 2024
asalzburger added a commit to asalzburger/acts that referenced this pull request May 21, 2024
This PR adds the necessary json conversion to write out ACTS BinnedSurfaceMaterial to detray material maps (in json).

The conversion now yields practically identical material in ACTS and detray:

<img width="887" alt="Screenshot 2024-05-06 at 17 12 27" src="https://github.com/acts-project/acts/assets/26623879/088df5b9-c30d-4b1b-9e70-02a717311031">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants