-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: MaterialInteractionAssignment empty intersections safety check #3158
Merged
kodiakhq
merged 4 commits into
acts-project:main
from
ssdetlab:intersection-material-assigner-empty-fix
Apr 30, 2024
Merged
fix: MaterialInteractionAssignment empty intersections safety check #3158
kodiakhq
merged 4 commits into
acts-project:main
from
ssdetlab:intersection-material-assigner-empty-fix
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊: Physics performance monitoring for 3e6442cphysmon summary
|
andiwand
approved these changes
Apr 29, 2024
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…cts-project#3158) Adding a small fix that checks for no intersections condition during the material interaction assignment. Previously the code could've segfaulted when accessing `intersectedSurfaces` in the `materialInteractions` loop.
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…cts-project#3158) Adding a small fix that checks for no intersections condition during the material interaction assignment. Previously the code could've segfaulted when accessing `intersectedSurfaces` in the `materialInteractions` loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a small fix that checks for no intersections condition during the material interaction assignment. Previously the code could've segfaulted when accessing
intersectedSurfaces
in thematerialInteractions
loop.