-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Add more comparison types for root files #3147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊: Physics performance monitoring for 672329bphysmon summary
|
andiwand
approved these changes
May 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3147 +/- ##
=======================================
Coverage 47.59% 47.59%
=======================================
Files 507 507
Lines 29135 29135
Branches 13976 13976
=======================================
Hits 13866 13866
Misses 5268 5268
Partials 10001 10001 ☔ View full report in Codecov by Sentry. |
acts-project-service
added
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
May 29, 2024
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 31, 2024
The previous file has been formatted with clang. `CHECK` has been renamed to `ASSERT` by convention. The types added are: - `TVectorT<float>` - `TEfficiency` - `TProfile` - `TH2F` For each of those, only the number of entries and the elements are compared.
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
The previous file has been formatted with clang. `CHECK` has been renamed to `ASSERT` by convention. The types added are: - `TVectorT<float>` - `TEfficiency` - `TProfile` - `TH2F` For each of those, only the number of entries and the elements are compared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Examples
Affects the Examples module
Fails Athena tests
This PR causes a failure in the Athena tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous file has been formatted with clang.
CHECK
has been renamed toASSERT
by convention.The types added are:
TVectorT<float>
TEfficiency
TProfile
TH2F
For each of those, only the number of entries and the elements are compared.