Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add more comparison types for root files #3147

Merged
merged 2 commits into from
May 28, 2024

Conversation

CouthuresJeremy
Copy link
Contributor

The previous file has been formatted with clang.
CHECK has been renamed to ASSERT by convention.

The types added are:

  • TVectorT<float>
  • TEfficiency
  • TProfile
  • TH2F

For each of those, only the number of entries and the elements are compared.

@github-actions github-actions bot added the Component - Examples Affects the Examples module label Apr 25, 2024
@AJPfleger AJPfleger added this to the next milestone Apr 25, 2024
@github-actions github-actions bot added the Stale label May 25, 2024
@andiwand andiwand added automerge and removed Stale labels May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.59%. Comparing base (a25c1da) to head (672329b).
Report is 254 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3147   +/-   ##
=======================================
  Coverage   47.59%   47.59%           
=======================================
  Files         507      507           
  Lines       29135    29135           
  Branches    13976    13976           
=======================================
  Hits        13866    13866           
  Misses       5268     5268           
  Partials    10001    10001           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 7b0a47e into acts-project:main May 28, 2024
52 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label May 29, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 31, 2024
The previous file has been formatted with clang.
`CHECK` has been renamed to `ASSERT` by convention.

The types added are:

- `TVectorT<float>`
- `TEfficiency`
- `TProfile`
- `TH2F`

For each of those, only the number of entries and the elements are compared.
@andiwand andiwand modified the milestones: next, v35.1.0 Jun 1, 2024
@CouthuresJeremy CouthuresJeremy deleted the root_comparison branch June 6, 2024 13:30
Matthewharri pushed a commit to Matthewharri/acts that referenced this pull request Jun 18, 2024
The previous file has been formatted with clang.
`CHECK` has been renamed to `ASSERT` by convention.

The types added are:

- `TVectorT<float>`
- `TEfficiency`
- `TProfile`
- `TH2F`

For each of those, only the number of entries and the elements are compared.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants