Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initial sigma qop coefficients for Examples TrackParamsEstimationAlgorithm #3111

Merged

Conversation

andiwand
Copy link
Contributor

Adds a qop coefficient term to the initial covariance of the estimated track parameters. Since the resolution of qop or p usually depends on the momentum itself this should allow us to model the initial curvature uncertainty more effectively and improve the track finding procedure.

@andiwand andiwand added this to the next milestone Apr 17, 2024
@github-actions github-actions bot added Component - Examples Affects the Examples module Track Finding labels Apr 17, 2024
@andiwand
Copy link
Contributor Author

ttbar PU 200
default seeding
fatras

image

@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Changes Performance labels Apr 18, 2024
Copy link
Contributor

@Corentin-Allaire Corentin-Allaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to say about the code ! Did you check how this affect the pull of qop ?

@andiwand
Copy link
Contributor Author

pull seems mostly unaffected

we could play a bit with the new param but maybe that is a story for another PR

image

Copy link
Contributor

@Corentin-Allaire Corentin-Allaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then lets go !

@kodiakhq kodiakhq bot merged commit f88bf42 into acts-project:main Apr 18, 2024
51 checks passed
@andiwand andiwand deleted the ex-feat-initial-sigma-qop-coefficients branch April 19, 2024 05:55
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Apr 19, 2024
…ationAlgorithm` (acts-project#3111)

Adds a `qop` coefficient term to the initial covariance of the estimated track parameters. Since the resolution of `qop` or `p` usually depends on the momentum itself this should allow us to model the initial curvature uncertainty more effectively and improve the track finding procedure.
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Apr 19, 2024
…ationAlgorithm` (acts-project#3111)

Adds a `qop` coefficient term to the initial covariance of the estimated track parameters. Since the resolution of `qop` or `p` usually depends on the momentum itself this should allow us to model the initial curvature uncertainty more effectively and improve the track finding procedure.
@andiwand andiwand removed this from the next milestone Apr 25, 2024
@andiwand andiwand added this to the v34.1.0 milestone Apr 25, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
…ationAlgorithm` (acts-project#3111)

Adds a `qop` coefficient term to the initial covariance of the estimated track parameters. Since the resolution of `qop` or `p` usually depends on the momentum itself this should allow us to model the initial curvature uncertainty more effectively and improve the track finding procedure.
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
…ationAlgorithm` (acts-project#3111)

Adds a `qop` coefficient term to the initial covariance of the estimated track parameters. Since the resolution of `qop` or `p` usually depends on the momentum itself this should allow us to model the initial curvature uncertainty more effectively and improve the track finding procedure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Component - Examples Affects the Examples module Infrastructure Changes to build tools, continous integration, ... Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants