-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: codecov coverage badge #3108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊: Physics performance monitoring for 35e463cphysmon summary
|
It seems, the problem solved itself. Let's close it for now and see, if it was just temporary. |
Seems the problem came back. |
andiwand
approved these changes
Apr 19, 2024
Ragansu
pushed a commit
to Ragansu/acts
that referenced
this pull request
Apr 19, 2024
badgen.net not work very stable for codecov and shows `404`. Use instead the badge generated by codecov: https://docs.codecov.com/docs/status-badges Change from ![badge-old](https://github.com/acts-project/acts/assets/70842573/45d22041-89bf-4a35-84b1-0a87c8627d47) to ![badge-new](https://github.com/acts-project/acts/assets/70842573/1017f1eb-63aa-41e0-931c-fcc196e975aa)
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
badgen.net not work very stable for codecov and shows `404`. Use instead the badge generated by codecov: https://docs.codecov.com/docs/status-badges Change from ![badge-old](https://github.com/acts-project/acts/assets/70842573/45d22041-89bf-4a35-84b1-0a87c8627d47) to ![badge-new](https://github.com/acts-project/acts/assets/70842573/1017f1eb-63aa-41e0-931c-fcc196e975aa)
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
badgen.net not work very stable for codecov and shows `404`. Use instead the badge generated by codecov: https://docs.codecov.com/docs/status-badges Change from ![badge-old](https://github.com/acts-project/acts/assets/70842573/45d22041-89bf-4a35-84b1-0a87c8627d47) to ![badge-new](https://github.com/acts-project/acts/assets/70842573/1017f1eb-63aa-41e0-931c-fcc196e975aa)
kodiakhq bot
pushed a commit
that referenced
this pull request
May 31, 2024
After - #3108 the badge did not update anymore. This was due to the wrong branch setting, after copying the suggestion from codecov. This removes any branch-specification and takes the default branch from ACTS. Since the documentation of codecov is not super clear, it might be necessary also to add a token in the future like this: ``` [![codecov](https://codecov.io/gh/acts-project/acts/graph/badge.svg?token=INSERT_TOKEN_HERE)](https://codecov.io/gh/acts-project/acts) ``` The token (different from the upload token) can be found at https://app.codecov.io/gh/acts-project/acts/settings/badge (login required). It seems to work without token for now, so no reason to expose it to the public.
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
After - acts-project#3108 the badge did not update anymore. This was due to the wrong branch setting, after copying the suggestion from codecov. This removes any branch-specification and takes the default branch from ACTS. Since the documentation of codecov is not super clear, it might be necessary also to add a token in the future like this: ``` [![codecov](https://codecov.io/gh/acts-project/acts/graph/badge.svg?token=INSERT_TOKEN_HERE)](https://codecov.io/gh/acts-project/acts) ``` The token (different from the upload token) can be found at https://app.codecov.io/gh/acts-project/acts/settings/badge (login required). It seems to work without token for now, so no reason to expose it to the public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
badgen.net not work very stable for codecov and shows
404
. Use instead the badge generated by codecov: https://docs.codecov.com/docs/status-badgesChange from to