Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: codecov coverage badge #3108

Merged
merged 3 commits into from
Apr 19, 2024
Merged

fix: codecov coverage badge #3108

merged 3 commits into from
Apr 19, 2024

Conversation

AJPfleger
Copy link
Contributor

@AJPfleger AJPfleger commented Apr 17, 2024

badgen.net not work very stable for codecov and shows 404. Use instead the badge generated by codecov: https://docs.codecov.com/docs/status-badges

Change from badge-old to badge-new

@AJPfleger AJPfleger added this to the next milestone Apr 17, 2024
@AJPfleger
Copy link
Contributor Author

It seems, the problem solved itself. Let's close it for now and see, if it was just temporary.

@AJPfleger AJPfleger closed this Apr 17, 2024
@AJPfleger
Copy link
Contributor Author

Seems the problem came back.

@AJPfleger AJPfleger reopened this Apr 18, 2024
@kodiakhq kodiakhq bot merged commit 93fc13d into acts-project:main Apr 19, 2024
53 checks passed
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Apr 19, 2024
@andiwand andiwand modified the milestones: next, v34.1.0 Apr 25, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
@AJPfleger AJPfleger deleted the codecov branch May 14, 2024 09:11
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
kodiakhq bot pushed a commit that referenced this pull request May 31, 2024
After
- #3108

the badge did not update anymore. This was due to the wrong branch setting, after copying the suggestion from codecov. This removes any branch-specification and takes the default branch from ACTS.

Since the documentation of codecov is not super clear, it might be necessary also to add a token in the future like this:
```
[![codecov](https://codecov.io/gh/acts-project/acts/graph/badge.svg?token=INSERT_TOKEN_HERE)](https://codecov.io/gh/acts-project/acts)
```
The token (different from the upload token) can be found at https://app.codecov.io/gh/acts-project/acts/settings/badge (login required). It seems to work without token for now, so no reason to expose it to the public.
Matthewharri pushed a commit to Matthewharri/acts that referenced this pull request Jun 18, 2024
After
- acts-project#3108

the badge did not update anymore. This was due to the wrong branch setting, after copying the suggestion from codecov. This removes any branch-specification and takes the default branch from ACTS.

Since the documentation of codecov is not super clear, it might be necessary also to add a token in the future like this:
```
[![codecov](https://codecov.io/gh/acts-project/acts/graph/badge.svg?token=INSERT_TOKEN_HERE)](https://codecov.io/gh/acts-project/acts)
```
The token (different from the upload token) can be found at https://app.codecov.io/gh/acts-project/acts/settings/badge (login required). It seems to work without token for now, so no reason to expose it to the public.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants