refactor: Refactor how the bound state covariance is handled without transport #3104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
📊: Physics performance monitoring for bd95e13physmon summary
|
AJPfleger
reviewed
Apr 17, 2024
AJPfleger
approved these changes
Apr 17, 2024
🔴 Athena integration test results [4461ca2]🔴 Some tests have failed!Please investigate the pipeline! |
acts-project-service
added
the
Fails Athena tests
Ragansu
pushed a commit
to Ragansu/acts
that referenced
this pull request
Apr 19, 2024
…transport (acts-project#3104) Refactors the internal wirings of `boundState` if no covariance transport is requested. Currently the function might still return a covariance depending on the state of the stepper. This is a workaround to access the covariance of the stepper in case it was transported before. I refactored this and left the responsibility to the caller to get a covariance in case it was transported before hand. While doing this I also removed some unnecessary initializations and removed `std::move`s from eigen objects because they do not have an effect.
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…transport (acts-project#3104) Refactors the internal wirings of `boundState` if no covariance transport is requested. Currently the function might still return a covariance depending on the state of the stepper. This is a workaround to access the covariance of the stepper in case it was transported before. I refactored this and left the responsibility to the caller to get a covariance in case it was transported before hand. While doing this I also removed some unnecessary initializations and removed `std::move`s from eigen objects because they do not have an effect.
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…transport (acts-project#3104) Refactors the internal wirings of `boundState` if no covariance transport is requested. Currently the function might still return a covariance depending on the state of the stepper. This is a workaround to access the covariance of the stepper in case it was transported before. I refactored this and left the responsibility to the caller to get a covariance in case it was transported before hand. While doing this I also removed some unnecessary initializations and removed `std::move`s from eigen objects because they do not have an effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the internal wirings of
boundStateif no covariance transport is requested. Currently the function might still return a covariance depending on the state of the stepper. This is a workaround to access the covariance of the stepper in case it was transported before.I refactored this and left the responsibility to the caller to get a covariance in case it was transported before hand.
While doing this I also removed some unnecessary initializations and removed
std::moves from eigen objects because they do not have an effect.