Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Branch aborter for track finding in Examples #3098

Merged
merged 10 commits into from
Apr 18, 2024

Conversation

andiwand
Copy link
Contributor

Adding a branch aborter to the track finding in the Examples Framework. This should spare some computation in case we encounter too many holes during the search.

@andiwand andiwand added this to the next milestone Apr 12, 2024
@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Component - Examples Affects the Examples module Track Finding labels Apr 12, 2024
@github-actions github-actions bot added the Component - Core Affects the Core module label Apr 12, 2024
@andiwand
Copy link
Contributor Author

ttbar PU 200
default smearing
fatras

image

I am a bit surprised that this does not cut the CPU time more effectively for ttbar PU 200. I suspected that there are a lot of fake seeds which would lead to stopped branches. Maybe the maximum for the chi2 measurement selector is too high.

@timadye
Copy link
Contributor

timadye commented Apr 17, 2024

I am a bit surprised that this does not cut the CPU time more effectively for ttbar PU 200. I suspected that there are a lot of fake seeds which would lead to stopped branches. Maybe the maximum for the chi2 measurement selector is too high.

The improvement was disappointing in Athena as well. There weren't a huge number of tracks with 3 holes - except at the ends. So it might do better when you can stop the track early.

I didn't yet investigate applying pT or eta cuts in the branch stopper. Those have to be looser than the default because they aren't well measured while still filtering the track.

@kodiakhq kodiakhq bot merged commit a2a0ac5 into acts-project:main Apr 18, 2024
53 checks passed
@andiwand andiwand deleted the ex-feat-ckf-branch-stopper branch April 18, 2024 08:20
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Apr 19, 2024
Adding a branch aborter to the track finding in the Examples Framework. This should spare some computation in case we encounter too many holes during the search.
@andiwand andiwand modified the milestones: next, v34.1.0 Apr 25, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
Adding a branch aborter to the track finding in the Examples Framework. This should spare some computation in case we encounter too many holes during the search.
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
Adding a branch aborter to the track finding in the Examples Framework. This should spare some computation in case we encounter too many holes during the search.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Component - Core Affects the Core module Component - Examples Affects the Examples module Infrastructure Changes to build tools, continous integration, ... Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants