-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Avoid creation of unused string in CKF #3090
Merged
kodiakhq
merged 1 commit into
acts-project:main
from
goetzgaycken:fix_avoid_unused_string_construction
Apr 9, 2024
Merged
perf: Avoid creation of unused string in CKF #3090
kodiakhq
merged 1 commit into
acts-project:main
from
goetzgaycken:fix_avoid_unused_string_construction
Apr 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
changed the title
Avoid creation of unused string.
perf: Avoid creation of unused string in CKF
Apr 9, 2024
andiwand
approved these changes
Apr 9, 2024
📊: Physics performance monitoring for 908f89cphysmon summary
|
Ragansu
pushed a commit
to Ragansu/acts
that referenced
this pull request
Apr 19, 2024
refactor: avoid creation of unused strings. Currently a string used for verbose logs is created always, which can be avoided.
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
refactor: avoid creation of unused strings. Currently a string used for verbose logs is created always, which can be avoided.
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
refactor: avoid creation of unused strings. Currently a string used for verbose logs is created always, which can be avoided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: avoid creation of unused strings.
Currently a string used for verbose logs is created always, which can be avoided.