Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deduplicate seeds during track finding in Examples #3088

Merged
merged 9 commits into from
Apr 11, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Apr 9, 2024

Deduplicate seeds during track finding in Examples by collecting all measurement triplets generated by found tracks.

@andiwand andiwand added this to the next milestone Apr 9, 2024
@andiwand
Copy link
Contributor Author

andiwand commented Apr 9, 2024

cc @stephenswat if you want to checkout my implementation

@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label Apr 9, 2024
@andiwand andiwand added the 🛑 blocked This item is blocked by another item label Apr 9, 2024
@andiwand
Copy link
Contributor Author

andiwand commented Apr 9, 2024

Quickly measured this. Seems to be a ~3x speedup

image

which is the result of deduplicated seed

15:27:24    TrackFinding   INFO      TrackFindingAlgorithm statistics:
15:27:24    TrackFinding   INFO      - total seeds: 33998
15:27:24    TrackFinding   INFO      - deduplicated seeds: 24611

Copy link
Contributor

@Corentin-Allaire Corentin-Allaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I think it might be a good idea to add a few more comments explaining how the duplicate removal works

@andiwand andiwand added 🚧 WIP Work-in-progress and removed 🛑 blocked This item is blocked by another item labels Apr 10, 2024
@andiwand
Copy link
Contributor Author

ttbar PU 200
fatras
default seeding

image

@andiwand andiwand removed the 🚧 WIP Work-in-progress label Apr 11, 2024
Copy link
Contributor

@Corentin-Allaire Corentin-Allaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change ! LGTM

@asalzburger
Copy link
Contributor

Excellent job!

@kodiakhq kodiakhq bot merged commit 22730e1 into acts-project:main Apr 11, 2024
53 checks passed
@andiwand andiwand deleted the feat-ex-ckf-deduplicate-seeds branch April 11, 2024 20:03
@acts-project-service
Copy link
Collaborator

acts-project-service commented Apr 11, 2024

🔴 Athena integration test results

Build job with this PR failed!

Please investigate the build job for the pipeline!

@andiwand andiwand modified the milestones: next, v34.0.0 Apr 15, 2024
@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Apr 15, 2024
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Apr 19, 2024
…t#3088)

Deduplicate seeds during track finding in Examples by collecting all measurement triplets generated by found tracks.
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
…t#3088)

Deduplicate seeds during track finding in Examples by collecting all measurement triplets generated by found tracks.
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
…t#3088)

Deduplicate seeds during track finding in Examples by collecting all measurement triplets generated by found tracks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Changes Performance Component - Examples Affects the Examples module Event Data Model Infrastructure Changes to build tools, continous integration, ... Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants