Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Method to add components to an existing track state #3075

Merged

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Apr 4, 2024

While working on the CKF I encountered the problem that track state components need to be created when the track state is created. Since the CKF will not smooth anymore after #2722 the user might want to add smoothed states to the existing track states without reallocating and copying all the existing states.

In case of the vector implementation the components will not be next to each other in the memory.

@andiwand andiwand added this to the next milestone Apr 4, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Event Data Model labels Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 41.37931% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 49.02%. Comparing base (05620d7) to head (09c0949).

Files Patch % Lines
...ts/EventData/detail/MultiTrajectoryTestsCommon.hpp 5.76% 0 Missing and 49 partials ⚠️
Core/src/EventData/VectorMultiTrajectory.cpp 93.75% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3075      +/-   ##
==========================================
- Coverage   49.05%   49.02%   -0.03%     
==========================================
  Files         494      494              
  Lines       28972    29059      +87     
  Branches    13741    13797      +56     
==========================================
+ Hits        14211    14247      +36     
  Misses       4929     4929              
- Partials     9832     9883      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulgessinger
Copy link
Member

Can you add a test for this?

@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Apr 4, 2024
@kodiakhq kodiakhq bot merged commit a8a032e into acts-project:main Apr 4, 2024
52 checks passed
@github-actions github-actions bot removed the automerge label Apr 4, 2024
@andiwand andiwand deleted the feat-trackstates-add-components branch April 5, 2024 09:07
andiwand added a commit that referenced this pull request Apr 11, 2024
Resurrect #2717 from @andiwand, updating to the latest `main`, and
removing earlier test (`MyTrackFindingAlgorithm`).

blocked by
- #3074
- #3075
- #3076
- #3077
- #3078
- #3086

---------

Co-authored-by: andiwand <[email protected]>
Co-authored-by: Tim Adye <[email protected]>
@andiwand andiwand modified the milestones: next, v34.0.0 Apr 15, 2024
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Apr 19, 2024
…ct#3075)

While working on the CKF I encountered the problem that track state components need to be created when the track state is created. Since the CKF will not smooth anymore after acts-project#2722 the user might want to add smoothed states to the existing track states without reallocating and copying all the existing states.

In case of the vector implementation the components will not be next to each other in the memory.
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Apr 19, 2024
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and
removing earlier test (`MyTrackFindingAlgorithm`).

blocked by
- acts-project#3074
- acts-project#3075
- acts-project#3076
- acts-project#3077
- acts-project#3078
- acts-project#3086

---------

Co-authored-by: andiwand <[email protected]>
Co-authored-by: Tim Adye <[email protected]>
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
…ct#3075)

While working on the CKF I encountered the problem that track state components need to be created when the track state is created. Since the CKF will not smooth anymore after acts-project#2722 the user might want to add smoothed states to the existing track states without reallocating and copying all the existing states.

In case of the vector implementation the components will not be next to each other in the memory.
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and
removing earlier test (`MyTrackFindingAlgorithm`).

blocked by
- acts-project#3074
- acts-project#3075
- acts-project#3076
- acts-project#3077
- acts-project#3078
- acts-project#3086

---------

Co-authored-by: andiwand <[email protected]>
Co-authored-by: Tim Adye <[email protected]>
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
…ct#3075)

While working on the CKF I encountered the problem that track state components need to be created when the track state is created. Since the CKF will not smooth anymore after acts-project#2722 the user might want to add smoothed states to the existing track states without reallocating and copying all the existing states.

In case of the vector implementation the components will not be next to each other in the memory.
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and
removing earlier test (`MyTrackFindingAlgorithm`).

blocked by
- acts-project#3074
- acts-project#3075
- acts-project#3076
- acts-project#3077
- acts-project#3078
- acts-project#3086

---------

Co-authored-by: andiwand <[email protected]>
Co-authored-by: Tim Adye <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Plugins Affects one or more Plugins Event Data Model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants