-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Method to add components to an existing track state #3075
Merged
kodiakhq
merged 7 commits into
acts-project:main
from
andiwand:feat-trackstates-add-components
Apr 4, 2024
Merged
feat: Method to add components to an existing track state #3075
kodiakhq
merged 7 commits into
acts-project:main
from
andiwand:feat-trackstates-add-components
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Affects the Core module
Event Data Model
labels
Apr 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3075 +/- ##
==========================================
- Coverage 49.05% 49.02% -0.03%
==========================================
Files 494 494
Lines 28972 29059 +87
Branches 13741 13797 +56
==========================================
+ Hits 14211 14247 +36
Misses 4929 4929
- Partials 9832 9883 +51 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 09c0949physmon summary
|
Can you add a test for this? |
paulgessinger
approved these changes
Apr 4, 2024
andiwand
added a commit
that referenced
this pull request
Apr 11, 2024
Resurrect #2717 from @andiwand, updating to the latest `main`, and removing earlier test (`MyTrackFindingAlgorithm`). blocked by - #3074 - #3075 - #3076 - #3077 - #3078 - #3086 --------- Co-authored-by: andiwand <[email protected]> Co-authored-by: Tim Adye <[email protected]>
Ragansu
pushed a commit
to Ragansu/acts
that referenced
this pull request
Apr 19, 2024
…ct#3075) While working on the CKF I encountered the problem that track state components need to be created when the track state is created. Since the CKF will not smooth anymore after acts-project#2722 the user might want to add smoothed states to the existing track states without reallocating and copying all the existing states. In case of the vector implementation the components will not be next to each other in the memory.
Ragansu
pushed a commit
to Ragansu/acts
that referenced
this pull request
Apr 19, 2024
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and removing earlier test (`MyTrackFindingAlgorithm`). blocked by - acts-project#3074 - acts-project#3075 - acts-project#3076 - acts-project#3077 - acts-project#3078 - acts-project#3086 --------- Co-authored-by: andiwand <[email protected]> Co-authored-by: Tim Adye <[email protected]>
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…ct#3075) While working on the CKF I encountered the problem that track state components need to be created when the track state is created. Since the CKF will not smooth anymore after acts-project#2722 the user might want to add smoothed states to the existing track states without reallocating and copying all the existing states. In case of the vector implementation the components will not be next to each other in the memory.
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and removing earlier test (`MyTrackFindingAlgorithm`). blocked by - acts-project#3074 - acts-project#3075 - acts-project#3076 - acts-project#3077 - acts-project#3078 - acts-project#3086 --------- Co-authored-by: andiwand <[email protected]> Co-authored-by: Tim Adye <[email protected]>
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…ct#3075) While working on the CKF I encountered the problem that track state components need to be created when the track state is created. Since the CKF will not smooth anymore after acts-project#2722 the user might want to add smoothed states to the existing track states without reallocating and copying all the existing states. In case of the vector implementation the components will not be next to each other in the memory.
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and removing earlier test (`MyTrackFindingAlgorithm`). blocked by - acts-project#3074 - acts-project#3075 - acts-project#3076 - acts-project#3077 - acts-project#3078 - acts-project#3086 --------- Co-authored-by: andiwand <[email protected]> Co-authored-by: Tim Adye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Core
Affects the Core module
Component - Plugins
Affects one or more Plugins
Event Data Model
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the CKF I encountered the problem that track state components need to be created when the track state is created. Since the CKF will not smooth anymore after #2722 the user might want to add smoothed states to the existing track states without reallocating and copying all the existing states.
In case of the vector implementation the components will not be next to each other in the memory.