feat: Add TransformRange helper #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a transforming range adapter, similar to what will be available with the C++20+ ranges library, but much less powerful.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3060 +/- ##
==========================================
+ Coverage 48.93% 48.98% +0.05%
==========================================
Files 488 489 +1
Lines 28918 28947 +29
Branches 13713 13713
==========================================
+ Hits 14152 14181 +29
Misses 4951 4951
Partials 9815 9815 ☔ View full report in Codecov by Sentry. |
niermann999
reviewed
Mar 26, 2024
|
@niermann999 I've simplified (I think) the typedefs, and straightened out (hopefully) the type deductions. Could you have another look? |
|
Added doc comments now. |
📊: Physics performance monitoring for 2f6323aphysmon summary
|
niermann999
approved these changes
Mar 27, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
This PR: - Marks all of the Gen1 interface of `TrackingVolume` as such, to indicate what we'll supersede in the future - Makes a slight adjustment to [`TransformRange`](#3060), for - Add internal vector of uniquely owned child `TrackingVolume`s in `TrackingVolume`, accessible in a const-preserving way through `TransformRange`. - Updates the `TrackingVolume` constructors, eliminating one convenience one we don't need, and start adding ones we'll use for Gen3 Blocked by: - #3060
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
This implements a transforming range adapter, similar to what will be available with the C++20+ ranges library, but much less powerful. I'm planning to use this to gate mutable access to inner structures like child volumes in `TrackingVolume`, by using the `ConstDereference` policy for this range helper, which will always dereference and convert to const.
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…roject#3064) This PR: - Marks all of the Gen1 interface of `TrackingVolume` as such, to indicate what we'll supersede in the future - Makes a slight adjustment to [`TransformRange`](acts-project#3060), for - Add internal vector of uniquely owned child `TrackingVolume`s in `TrackingVolume`, accessible in a const-preserving way through `TransformRange`. - Updates the `TrackingVolume` constructors, eliminating one convenience one we don't need, and start adding ones we'll use for Gen3 Blocked by: - acts-project#3060
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
This implements a transforming range adapter, similar to what will be available with the C++20+ ranges library, but much less powerful. I'm planning to use this to gate mutable access to inner structures like child volumes in `TrackingVolume`, by using the `ConstDereference` policy for this range helper, which will always dereference and convert to const.
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…roject#3064) This PR: - Marks all of the Gen1 interface of `TrackingVolume` as such, to indicate what we'll supersede in the future - Makes a slight adjustment to [`TransformRange`](acts-project#3060), for - Add internal vector of uniquely owned child `TrackingVolume`s in `TrackingVolume`, accessible in a const-preserving way through `TransformRange`. - Updates the `TrackingVolume` constructors, eliminating one convenience one we don't need, and start adding ones we'll use for Gen3 Blocked by: - acts-project#3060
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a transforming range adapter, similar to what will be available with the C++20+ ranges library, but much less powerful.
I'm planning to use this to gate mutable access to inner structures like child volumes in
TrackingVolume, by using theConstDereferencepolicy for this range helper, which will always dereference and convert to const.