Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Always order by event number for ROOT input in Examples #3046

Merged
merged 18 commits into from
Mar 26, 2024

Conversation

andiwand
Copy link
Contributor

This is a pitfall when using multi-threading. I think we can afford sorting by default.

Also cleans out some IO code and renames the whiteboard prop names.

@andiwand andiwand added this to the next milestone Mar 20, 2024
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.91%. Comparing base (5655f98) to head (a563af2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3046   +/-   ##
=======================================
  Coverage   48.91%   48.91%           
=======================================
  Files         488      488           
  Lines       28896    28896           
  Branches    13708    13708           
=======================================
  Hits        14134    14134           
  Misses       4947     4947           
  Partials     9815     9815           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andiwand andiwand changed the title refactor: Always order by event number while reading in Examples refactor: Always order by event number for ROOT reading in Examples Mar 20, 2024
@andiwand andiwand changed the title refactor: Always order by event number for ROOT reading in Examples refactor: Always order by event number for ROOT input in Examples Mar 20, 2024
@AJPfleger
Copy link
Contributor

Do you think, we could split this PR into 2?

  • Always order by event number for ROOT input in Examples
  • Clean up and IO and whiteboard

@andiwand
Copy link
Contributor Author

In principle that would be preferable but since this is only about the examples framework I don't really see a benefit in that

@andiwand andiwand requested a review from AJPfleger March 26, 2024 13:24
@kodiakhq kodiakhq bot merged commit e9943d3 into acts-project:main Mar 26, 2024
54 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Mar 26, 2024
@andiwand andiwand deleted the ex-reader-always-order branch March 27, 2024 08:11
@andiwand andiwand removed the Fails Athena tests This PR causes a failure in the Athena tests label Apr 10, 2024
@andiwand andiwand modified the milestones: next, v34.1.0 Apr 25, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
…ts-project#3046)

This is a pitfall when using multi-threading. I think we can afford sorting by default.

Also cleans out some IO code and renames the whiteboard prop names.
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
…ts-project#3046)

This is a pitfall when using multi-threading. I think we can afford sorting by default.

Also cleans out some IO code and renames the whiteboard prop names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants