-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Always order by event number for ROOT input in Examples #3046
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3046 +/- ##
=======================================
Coverage 48.91% 48.91%
=======================================
Files 488 488
Lines 28896 28896
Branches 13708 13708
=======================================
Hits 14134 14134
Misses 4947 4947
Partials 9815 9815 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for c14bea8physmon summary
|
…o ex-reader-always-order
f6ae4cc
to
02a3cab
Compare
Do you think, we could split this PR into 2?
|
In principle that would be preferable but since this is only about the examples framework I don't really see a benefit in that |
Co-authored-by: Alexander J. Pfleger <[email protected]>
Co-authored-by: Alexander J. Pfleger <[email protected]>
🔴 Athena integration test results [e9943d3]🔴 Some tests have failed!Please investigate the pipeline! |
…ts-project#3046) This is a pitfall when using multi-threading. I think we can afford sorting by default. Also cleans out some IO code and renames the whiteboard prop names.
…ts-project#3046) This is a pitfall when using multi-threading. I think we can afford sorting by default. Also cleans out some IO code and renames the whiteboard prop names.
This is a pitfall when using multi-threading. I think we can afford sorting by default.
Also cleans out some IO code and renames the whiteboard prop names.