feat: new global / bound to grid local access schema #3039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3039 +/- ##
==========================================
- Coverage 48.82% 48.81% -0.01%
==========================================
Files 489 489
Lines 28891 28883 -8
Branches 13711 13711
==========================================
- Hits 14105 14099 -6
+ Misses 4957 4955 -2
Partials 9829 9829 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for cf7179fphysmon summary
|
asalzburger
force-pushed
the
feat-refined-grid-material-and-io
branch
from
3c01c86
to
a580f23
Compare
github-actions
bot
added
Component - Examples
github-actions
bot
removed
Component - Examples
asalzburger
requested review from
dimitra97
and removed request for
paulgessinger
|
Hi @dimitra97 - as you looked over the first PR #3012 (closed), this is the update that takes some discussion input into account. The idea is to have Global->GridLocal and Bound->GridLocal in delegates. For the moment, this is only done for the |
andiwand
reviewed
Mar 19, 2024
dimitra97
reviewed
Mar 19, 2024
|
Hey @andiwand @dimitra97 - I think I addressed your comments as much as I can. |
dimitra97
reviewed
Mar 20, 2024
andiwand
approved these changes
Mar 20, 2024
dimitra97
approved these changes
Mar 20, 2024
acts-project-service
added
the
Breaks Athena build
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
Based on the discussion on acts-project#3012 - this PR introduces a different, harmonised way to do global -> grid_local or bound/local -> grid_local, more in line of what we do in the Magnetic field. The owning delegate is needed for persistency and displaying. If this is accepted as a new approach to do that, I will update also the grid based navigation structures with that.
asalzburger
added a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
Based on the discussion on acts-project#3012 - this PR introduces a different, harmonised way to do global -> grid_local or bound/local -> grid_local, more in line of what we do in the Magnetic field. The owning delegate is needed for persistency and displaying. If this is accepted as a new approach to do that, I will update also the grid based navigation structures with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion on #3012 - this PR introduces a different, harmonised way to do global -> grid_local or bound/local -> grid_local, more in line of what we do in the Magnetic field.
The owning delegate is needed for persistency and displaying.
If this is accepted as a new approach to do that, I will update also the grid based navigation structures with that.