refactor: Refactor OpenDataDetector path discovery in Examples #3036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Infrastructure
asalzburger
previously approved these changes
Mar 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3036 +/- ##
=======================================
Coverage 48.82% 48.82%
=======================================
Files 491 491
Lines 28886 28886
Branches 13705 13705
=======================================
Hits 14104 14104
Misses 4954 4954
Partials 9828 9828 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 134611cphysmon summary
|
asalzburger
approved these changes
Mar 14, 2024
🔴 Athena integration test results [682d208]🔴 Some tests have failed!Please investigate the pipeline! |
acts-project-service
added
the
Fails Athena tests
dimitra97
pushed a commit
to dimitra97/acts
that referenced
this pull request
Mar 19, 2024
…project#3036) We currently require to point the python path into a python examples directory so we can discover the ODD directory automatically. I think it might be easier to require setting an environment variable for the ODD path and start discovery from there. This ODD path will be automatically set by `python/setup.sh`. Apart from that the user can set a path manually as before.
andiwand
removed
the
Fails Athena tests
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…project#3036) We currently require to point the python path into a python examples directory so we can discover the ODD directory automatically. I think it might be easier to require setting an environment variable for the ODD path and start discovery from there. This ODD path will be automatically set by `python/setup.sh`. Apart from that the user can set a path manually as before.
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…project#3036) We currently require to point the python path into a python examples directory so we can discover the ODD directory automatically. I think it might be easier to require setting an environment variable for the ODD path and start discovery from there. This ODD path will be automatically set by `python/setup.sh`. Apart from that the user can set a path manually as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently require to point the python path into a python examples directory so we can discover the ODD directory automatically. I think it might be easier to require setting an environment variable for the ODD path and start discovery from there.
This ODD path will be automatically set by
python/setup.sh. Apart from that the user can set a path manually as before.