feat: update Open Data Detector to v4.0.1

[asalzburger]

This PR updates the open data detector to v4.0.1, which will enable it to built in Gen1-style and Gen2-style geometry.

Small performance changes are expected, since v4.0.1 also contains a few tiny geometry fixes.

This PR increases the 'examples' run time from 11 to 15 because it will run Geant4 material recording also in the Calorimeter (which is on by default) in the ODD ...

[github-actions]

📊: Physics performance monitoring for bf0bfa3

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Truth tracking (GX2F)
• ✅ Particles fatras
• ✅ Particles geant4

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.82%. Comparing base (682d208) to head (bf0bfa3).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2992   +/-   ##
=======================================
  Coverage   48.82%   48.82%           
=======================================
  Files         491      491           
  Lines       28886    28886           
  Branches    13705    13705           
=======================================
  Hits        14104    14104           
  Misses       4954     4954           
  Partials     9828     9828           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[andiwand]

Something related to time seems to be broken

that might explain the other differences

[andiwand]

https://gitlab.cern.ch/acts/OpenDataDetector/-/merge_requests/87

[andiwand]

Output looks much more sane now. To me it looks like we shuffle around some outliers which triggers all the physmon failure.

No objections from my side.

[asalzburger]

@andiwand @paulgessinger Any thoughts on the example_test runtime increase due to the calorimeter being built per default?

I tried to introduce <xlst:choose> condition paired with environment variables to make it switchable without changing the xml file, but could not get it to run with the DD4hep xml schema. For the moment, I guess we have to live with it, then we could change the ODD xml setup to DD4hep style.

<your application> OdenDataDetector.xml OpenDataTracker.xml OpenDataCalorimeter.xml 

[paulgessinger]

@asalzburger how much are we talking here? I wouldn't have expected this to be large increase on the ACTS side, is this driven by DD4hep taking longer to construct?

[andiwand]

What is the runtime increase?

Alternatively we could have different ODD xml root files I guess? One with and one without the calo.
Or we split it completely like you proposed.

[asalzburger]

@asalzburger how much are we talking here? I wouldn't have expected this to be large increase on the ACTS side, is this driven by DD4hep taking longer to construct?

Testing goes from 11min to 15mins, and it's practically driven by the material_recording and genat4 simulation now seeing a calorimeter.

[asalzburger]

What is the runtime increase?

Alternatively we could have different ODD xml root files I guess? One with and one without the calo. Or we split it completely like you proposed.

Yeah, I guess we'd have to do some "OpenDataDetectorTrackerOnly.xml"

[asalzburger]

@andiwand - just to make sure, as you merged in AMVF changes int he meantime, the performance reference needs to be updated - looks all good to me, but if you could have another look, I will update the file.

[andiwand]

this is the usual problem with concurrent reference file changes. there is one more ref change in the pipeline #3034. afterwards we can proceed with this one

to me 11->15 min sounds not too bad. also these numbers fluctuate quite a bit depending on our load

[acts-project-service]

✅ Athena integration test results [4f33d42]

✅ All tests successful

status	job	report
🟢	run_unit_tests
🟢	test_ActsEFTrackFit
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsConversionWorkflow
🟢	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsPersistifyEDM
🟢	test_ActsGSFRefitting
🟢	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🟢	test_ActsITkTest
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco