Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Geant4SurfaceProvider gdml schema validation fix #2956

Conversation

ssdetlab
Copy link
Contributor

Making the validation of the GDML file schema optional when parsing the files.

Mainly added so that the tests could be decoupled from the state of the servers with the .xsd files.

@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Feb 17, 2024
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (003a0e8) 48.85% compared to head (e401058) 48.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2956   +/-   ##
=======================================
  Coverage   48.85%   48.85%           
=======================================
  Files         495      495           
  Lines       28906    28906           
  Branches    13731    13731           
=======================================
  Hits        14121    14121           
  Misses       4899     4899           
  Partials     9886     9886           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulgessinger paulgessinger added this to the next milestone Feb 18, 2024
@kodiakhq kodiakhq bot merged commit 0c753b1 into acts-project:main Feb 18, 2024
56 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Feb 18, 2024
@paulgessinger paulgessinger modified the milestones: next, v33.0.0 Mar 6, 2024
@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Mar 6, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
)

Making the validation of the GDML file schema optional when parsing the files. 

Mainly added so that the tests could be decoupled from the state of the servers with the .xsd files.
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
)

Making the validation of the GDML file schema optional when parsing the files. 

Mainly added so that the tests could be decoupled from the state of the servers with the .xsd files.
@ssdetlab ssdetlab deleted the geant4-surface-provider-test-gdml-schema-validation-fix branch October 11, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Plugins Affects one or more Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants