-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Geant4SurfaceProvider gdml schema validation fix #2956
Merged
kodiakhq
merged 3 commits into
acts-project:main
from
ssdetlab:geant4-surface-provider-test-gdml-schema-validation-fix
Feb 18, 2024
Merged
fix: Geant4SurfaceProvider gdml schema validation fix #2956
kodiakhq
merged 3 commits into
acts-project:main
from
ssdetlab:geant4-surface-provider-test-gdml-schema-validation-fix
Feb 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2956 +/- ##
=======================================
Coverage 48.85% 48.85%
=======================================
Files 495 495
Lines 28906 28906
Branches 13731 13731
=======================================
Hits 14121 14121
Misses 4899 4899
Partials 9886 9886 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for e401058physmon summary
|
paulgessinger
approved these changes
Feb 18, 2024
🔴 Athena integration test results [0c753b1]🔴 Some tests have failed!Please investigate the pipeline! |
acts-project-service
added
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Feb 18, 2024
paulgessinger
removed
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Mar 6, 2024
ssdetlab
deleted the
geant4-surface-provider-test-gdml-schema-validation-fix
branch
October 11, 2024 12:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the validation of the GDML file schema optional when parsing the files.
Mainly added so that the tests could be decoupled from the state of the servers with the .xsd files.