refactor: KalmanVertex(Track)Updater interface change

[paulgessinger]

This changes the interface found in KalmanVertexUpdater and KalmanVertexTrackUpdater to handling the dispatch into 3 and 4 dimensions at runtime inside their respective compilation units.

Part of:

• refactor: Vertex implementation #2842

Blocked by:

• feat!: Add IVertexFinder interface, use in vertexing #2948

[codecov]

Codecov Report

Attention: 81 lines in your changes are missing coverage. Please review.

Comparison is base (148e0e3) 48.82% compared to head (0489b93) 48.78%.

Files	Patch %	Lines
Core/src/Vertexing/KalmanVertexUpdater.cpp	24.03%	3 Missing and 76 partials ⚠️
...clude/Acts/Vertexing/AdaptiveMultiVertexFitter.ipp	50.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2955      +/-   ##
==========================================
- Coverage   48.82%   48.78%   -0.05%     
==========================================
  Files         496      493       -3     
  Lines       28938    28914      -24     
  Branches    13751    13752       +1     
==========================================
- Hits        14130    14105      -25     
  Misses       4909     4909              
- Partials     9899     9900       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📊: Physics performance monitoring for 0489b93

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles fatras
• ✅ Particles geant4

[paulgessinger]

Refactored again now @andiwand. I think the duplication of functions should be resolved now, and only two functions remain in the header.

[andiwand]

awesome!

[acts-project-service]

✅ Athena integration test results [1e6c8b3]

✅ All tests successful

status	job	report
🟢	run_unit_tests
🟢	test_ActsEFTrackFit
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsConversionWorkflow
🟢	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsPersistifyEDM
🟢	test_ActsGSFRefitting
🟢	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🟢	test_ActsITkTest
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco