Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Add IVertexFinder interface, use in vertexing #2948

Merged
merged 15 commits into from
Feb 19, 2024
Merged

feat!: Add IVertexFinder interface, use in vertexing #2948

merged 15 commits into from
Feb 19, 2024

Commits on Feb 16, 2024

  1. Add IVertexFinder and basic compliance + usage

    @paulgessinger
    paulgessinger committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    32be500 View commit details
    Browse the repository at this point in the history

  2. VertexFinders use Seeders as interface finders 

    AMVFinderAlg sets up finder at construction now (not execute)
    @paulgessinger
    paulgessinger committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    b37ef5f View commit details
    Browse the repository at this point in the history

  3. fix: require setTracksToRemove to fix perf regression

    @paulgessinger
    paulgessinger committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    9722945 View commit details
    Browse the repository at this point in the history

  4. fixup: GridDensityVertexFinder::setTracksToRemove

    @paulgessinger
    paulgessinger committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    e146a22 View commit details
    Browse the repository at this point in the history

  5. Add virtual destructor to IVertexFinder

    @paulgessinger
    paulgessinger committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    c3e9bb2 View commit details
    Browse the repository at this point in the history

  6. fix format

    @paulgessinger
    paulgessinger committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    d1fd468 View commit details
    Browse the repository at this point in the history

  7. Remove VertexFitterConcept (it's not useful at the moment)

    @paulgessinger
    paulgessinger committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    8bb6302 View commit details
    Browse the repository at this point in the history

  8. IVertexFinder::makeState accepts magnetic field context

    @paulgessinger
    paulgessinger committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    4cbae00 View commit details
    Browse the repository at this point in the history

  9. Remove hasTrivialState

    @paulgessinger
    paulgessinger committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    29213f8 View commit details
    Browse the repository at this point in the history

  10. thisState -> anyState

    @paulgessinger
    paulgessinger committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    b18541e View commit details
    Browse the repository at this point in the history

  11. Add doxygen comments for IVertexFinder

    @paulgessinger
    paulgessinger committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    ed6f6c9 View commit details
    Browse the repository at this point in the history

  12. fix shadowing

    @paulgessinger
    paulgessinger committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    dff71c5 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Add b field to IVF in examples algo

    @paulgessinger
    paulgessinger committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    4c4853e View commit details
    Browse the repository at this point in the history

  2. remove dead code

    @paulgessinger
    paulgessinger committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    ed9b41e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into refactor/vtx-templates-part7-ivertexfinder

    @kodiakhq
    kodiakhq[bot] authored Feb 19, 2024
    Configuration menu
    Copy the full SHA
    ff46291 View commit details
    Browse the repository at this point in the history